Handle locked-period timer saves and surface errors in web and TUI#103
Handle locked-period timer saves and surface errors in web and TUI#103
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d54c74a7a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ponbac
force-pushed
the
96/handle-locked-period-timer-saves-and-surface-errors-in-web-and-tui
branch
from
d54c74a to
13b1565
Compare
|
Addressed review note from https://github.com/ponbac/toki2/pull/103#discussion_r2894987061.\n\nChange made: blank-body 404 responses are no longer classified as locked periods; added regression test to keep blank 404 as unknown error.\n\n@codex please re-review. |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Should be able to use zod here in order to make it cleaner.
| body, | ||
| } => { | ||
| let body_lower = body.to_lowercase(); | ||
| body_lower.contains("timer not found") |
There was a problem hiding this comment.
This should be checked against Milltime, what the real response is.
1 participant
Handle locked-period timer saves and surface errors in web and TUI
Fixes #96