Skip to content

Fix floating timer blur/edit race#104

Merged
ponbac merged 1 commit intomasterfrom
fix/floating-timer-edit-race
Mar 6, 2026
Merged

Fix floating timer blur/edit race#104
ponbac merged 1 commit intomasterfrom
fix/floating-timer-edit-race

Conversation

@ponbac
Copy link
Owner

@ponbac ponbac commented Mar 6, 2026

Summary

  • open the timer edit dialog with the current floating-note draft so blur+click Edit cannot show stale note
  • optimistically update the active timer React Query cache in useEditTimer
  • roll back optimistic cache on mutation failure and invalidate on settle for server reconciliation

Verification

  • just tsc
  • just lint

@vercel
Copy link

vercel bot commented Mar 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
toki2 Ready Ready Preview, Comment Mar 6, 2026 0:39am

Request Review

@ponbac
Copy link
Owner Author

ponbac commented Mar 6, 2026

@codex

- Open timer edit dialog with current floating-note draft
- Optimistically update timer query cache in useEditTimer
- Roll back optimistic timer cache update on mutation error
- Keep final invalidate on settle for server reconciliation
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5cba4d1f7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ponbac ponbac merged commit e53dd84 into master Mar 6, 2026
7 checks passed
@ponbac ponbac deleted the fix/floating-timer-edit-race branch March 6, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant