Skip to content

Scope com.ibm.wala.cast.python.jython.test's resource directory#377

Open
khatchad wants to merge 1 commit into
masterfrom
fix-jython-test-recursive-resources
Open

Scope com.ibm.wala.cast.python.jython.test's resource directory#377
khatchad wants to merge 1 commit into
masterfrom
fix-jython-test-recursive-resources

Conversation

@khatchad

Copy link
Copy Markdown
Member

com.ibm.wala.cast.python.jython.test declared its build resource as <directory>.</directory> with no <includes>, so the maven-resources-plugin copied the entire module directory — including target/ — into target/classes/ on every build. Each build therefore nested target/classes/target/classes/... one level deeper, eventually exhausting disk and inodes (a single local checkout reached 204 GB).

The sibling test modules were already scoped — com.ibm.wala.cast.python.test to data and com.ibm.wala.cast.python.jython3.test to META-INF/** + build.properties (the wala#156 "make test directories a resource" fix) — but this module was overlooked. This scopes it the same way as jython3.test.

Verified: after the change, target/classes/ contains only META-INF, build.properties, and the compiled com/ package — no nested target/.

🤖 Generated with Claude Code

The module copied its entire directory (`<directory>.</directory>` with
no includes) into `target/classes`, so each build recursively nested
`target/classes/target/classes/...` — eventually exhausting disk and
inodes (a single checkout reached 204 GB). Scope the resource to the
files actually needed (`META-INF/**`, `build.properties`), matching the
sibling `com.ibm.wala.cast.python.jython3.test` and the `data`-scoped
`com.ibm.wala.cast.python.test` (the wala#156 fix that this module was
overlooked by).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an overly broad Maven resources configuration in com.ibm.wala.cast.python.jython.test that caused the entire module directory (including target/) to be copied into target/classes/, leading to recursive target/classes/target/classes/... growth and eventual disk/inode exhaustion during repeated builds.

Changes:

  • Restricts the module’s build resources from . (entire module) to only META-INF/** and build.properties.
  • Aligns com.ibm.wala.cast.python.jython.test resource scoping with the existing pattern used by com.ibm.wala.cast.python.jython3.test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.67%. Comparing base (cf20354) to head (72ea971).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #377   +/-   ##
=========================================
  Coverage     71.67%   71.67%           
  Complexity     2731     2731           
=========================================
  Files           272      272           
  Lines         20347    20347           
  Branches       3283     3283           
=========================================
  Hits          14583    14583           
  Misses         4470     4470           
  Partials       1294     1294           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants