Scope com.ibm.wala.cast.python.jython.test's resource directory#377
Open
khatchad wants to merge 1 commit into
Open
Scope com.ibm.wala.cast.python.jython.test's resource directory#377khatchad wants to merge 1 commit into
com.ibm.wala.cast.python.jython.test's resource directory#377khatchad wants to merge 1 commit into
Conversation
The module copied its entire directory (`<directory>.</directory>` with no includes) into `target/classes`, so each build recursively nested `target/classes/target/classes/...` — eventually exhausting disk and inodes (a single checkout reached 204 GB). Scope the resource to the files actually needed (`META-INF/**`, `build.properties`), matching the sibling `com.ibm.wala.cast.python.jython3.test` and the `data`-scoped `com.ibm.wala.cast.python.test` (the wala#156 fix that this module was overlooked by). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes an overly broad Maven resources configuration in com.ibm.wala.cast.python.jython.test that caused the entire module directory (including target/) to be copied into target/classes/, leading to recursive target/classes/target/classes/... growth and eventual disk/inode exhaustion during repeated builds.
Changes:
- Restricts the module’s build resources from
.(entire module) to onlyMETA-INF/**andbuild.properties. - Aligns
com.ibm.wala.cast.python.jython.testresource scoping with the existing pattern used bycom.ibm.wala.cast.python.jython3.test.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
=========================================
Coverage 71.67% 71.67%
Complexity 2731 2731
=========================================
Files 272 272
Lines 20347 20347
Branches 3283 3283
=========================================
Hits 14583 14583
Misses 4470 4470
Partials 1294 1294 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
com.ibm.wala.cast.python.jython.testdeclared its build resource as<directory>.</directory>with no<includes>, so themaven-resources-plugincopied the entire module directory — includingtarget/— intotarget/classes/on every build. Each build therefore nestedtarget/classes/target/classes/...one level deeper, eventually exhausting disk and inodes (a single local checkout reached 204 GB).The sibling test modules were already scoped —
com.ibm.wala.cast.python.testtodataandcom.ibm.wala.cast.python.jython3.testtoMETA-INF/**+build.properties(the wala#156 "make test directories a resource" fix) — but this module was overlooked. This scopes it the same way asjython3.test.Verified: after the change,
target/classes/contains onlyMETA-INF,build.properties, and the compiledcom/package — no nestedtarget/.🤖 Generated with Claude Code