feat(next): accept Promise<Queue[]> for queues#48
Open
omarzeineddine-ai wants to merge 1 commit into
Open
Conversation
Apps that collect queues asynchronously (e.g. via an async registry helper) previously had to block or work around the sync-only queues field. The adapter now also accepts a promise: the handler is built once the promise resolves, requests arriving earlier wait for it, and a rejected promise surfaces on each request instead of crashing the server as an unhandled rejection. Sync usage is unchanged and still builds the handler eagerly. Closes pontusab#46
|
@omarzeineddine-ai is attempting to deploy a commit to the Pontus Abrahamsson's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #46
The Next.js adapter only accepted
queues: Queue[]. Apps that collect their queues asynchronously (the issue author has 40+ queues behind an async helper) had no way to pass them without blocking module evaluation.Solution
queuesnow also acceptsPromise<Queue[]>:Tests
Added
packages/next/src/index.test.tscovering sync queues, promised queues, single resolution across handlers/requests, and rejection behavior. Verified withbun test,tsc --noEmit,tsupbuild, and biome lint inpackages/next.