Add "auto unstack" switch#1657
Conversation
|
|
jacobgkau
left a comment
There was a problem hiding this comment.
This doesn't seem to be working. After turning the option on, I can still move windows out of a stack and have a single remaining window remain in the stack, rather than having the stack be destroyed.
simplescreenrecorder-2023-10-12_17.37.42.mp4
The most recent commit also broke the tab bar's formatting, as shown in the above video (the commit message includes do not PR, so I assume pushing it here was a mistake?)
Oh no, I didn't mean to PR the recent commit, I think it just did it automatically. I'll try to remove the commit. Also, it might not be working because my commit might have only affected mouse stacking - I based my code off of the code that reverted this stacking behaviour, so I'm not sure how to also make it apply to keyboard stacking. |
5a7a888 to
adeb087
Compare
The current wording of the setting:
...does not reflect that it's specific to the mouse. If you don't want to get it working for the keyboard, then you could alternatively tweak the wording so it's more indicative of what it does, e.g.:
(The wording could be nicer, but I tried to limit the length and also match the wording of existing settings in this panel.) |
Well, I do want to accomodate for keyboard stacking, I just don't know how to. But, if it's just fine with the mouse, it could be called "Destroy stacks when separated with mouse" or something like that. |
src/prefs.ts
Outdated
| xalign: 0.0 | ||
| }) | ||
| xalign: 0.0, | ||
| }); |
There was a problem hiding this comment.
It's probably best if you go ahead and revert the unnecessary formatting changes.
See "Sisyphus" for what my editor tried to do to me while changing this
There was a problem hiding this comment.
This is me trying to move the imports back to their rightful place


Create a toggle switch in the settings to enable destroying stacks when they have only one window.
This is my first PR, and it "works on my machine" when I run
make debug. There still might be bugs, though.My system specs: