Edited Inactive Tab Color for More Intuitive Selection#1786
Edited Inactive Tab Color for More Intuitive Selection#1786andrewtran3643 wants to merge 3 commits intopop-os:master_noblefrom
Conversation
for light active hint colors, edited the text color of inactive tabs to blend in indicating inactivity
|
@andrewtran3643 Hadn't gotten a chance to look at this yet, sorry (our attention's mostly turned towards COSMIC Epoch, which no longer uses Pop!_Shell). I'll take a look at this on behalf of QA tomorrow. I do think it makes sense to derive the inactive tab color from the active hint color so it matches the active tab color. Shouldn't be any problems as long as it works as expected. |
jacobgkau
left a comment
There was a problem hiding this comment.
This is definitely an improvement for non-default active hint colors. However, I'm a little concerned that the difference between active & inactive tabs is less noticeable now.
@andrewtran3643 Would you be able to try and change the shading to match the inactive tab color to what it used to be a little closer when the hint color's set to the default? It doesn't have to be 100% exact, but it seems like e.g. reducing the saturation a bit might get closer to what it used to be. Seems like it could also benefit darker hint colors.







The inactive tab color was hard-coded to
#9B8E8A. When using a dark active hint color, the inactive tab appears lighter than the active tab, which can make it seem like the inactive tab is selected.This PR updates the inactive tab color to use the active hint color, darkened by 20%, and slightly adjusts the text color to be darker for inactive tabs.
This is my first PR—thank you for your patience, and I appreciate any feedback!