Refine statement range parse error behavior#1030
Open
DavisVaughan wants to merge 1 commit intomainfrom
Open
Conversation
Only refuse to provide a statement range after detecting the first top-level expression that contains a parse error somewhere within it. This allows top-level statements before this one to still be executed.
Member
|
I've got Positron using a debug build of ark from this PR and it LGTM so far. I'll continue to exercise it implicitly and explicitly and report back anything interesting. |
jennybc
reviewed
Feb 6, 2026
| // Refuse to provide a statement range after detecting a top-level `child` with a | ||
| // parse error. We expect that everything before this top-level `child` has parsed | ||
| // correctly, so if the cursor was above this first parse error, we can execute | ||
| // that code fearlessly. After the first parse error, all bets are off. Even if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of posit-dev/positron#8350
Part of posit-dev/positron#5023
Part 1 of the statement range refinement plan
Only refuse to provide a statement range after detecting the first top-level expression that contains a parse error somewhere within it. We assert that anything before this has parsed correctly, so if the user's cursor is up there, we should be able to compute a statement range (we are mostly confident in this assertion, I cannot think of any examples where it would not hold).
This matches Mine's expectations over in posit-dev/positron#8350 of