fix(bakery): apply image_name filter in ci matrix command#608
Merged
Conversation
The matrix command was iterating c.model.images (all images, unfiltered) instead of applying the image_name regex from BakeryConfigFilter, causing patterns like 'workbench$' to match prefix-colliding names like 'workbench-session-init'. Adds a regression test using the existing merge-multi-image context. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Test Results1 863 tests 1 863 ✅ 8m 35s ⏱️ Results for commit 759cca5. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bakery ci matrix <image_name>was iteratingc.model.images(the unfiltered list) instead of applying theimage_nameregex fromBakeryConfigFilterworkbench$would match prefix-colliding image names likeworkbench-session-initbecause the filter was never consultedre.search(image_name, i.name)inline on the image list, consistent with howgenerate_image_targets()applies the same filterTest plan
matrix.featureusing the existingmerge-multi-imagecontext (test-alpha/test-alpha-extra) verifies thattest-alpha$returns onlytest-alphatest_ci.pytests passbakery ci matrix 'workbench$'inimages-workbench/now returns onlyworkbenchentries🤖 Generated with Claude Code