Notify Slack on merge queue failures#127
Draft
bschwedler wants to merge 5 commits into
Draft
Conversation
Add a notification step to the CI job, conditioned on merge_group events, so that merge queue failures trigger a Slack alert. Adds an id to the alls-green step so its outcome is referenceable.
Without this trigger, the workflow never runs on merge_group events, so the github.event_name == 'merge_group' condition in the Slack notification step was never satisfied — effectively dead code.
For pull_request events, pass latest-only=true to all three build jobs (production, development, session). For merge_group events, latest-only defaults to false so the full version matrix runs. Requires images-shared to expose the latest-only input on bakery-build-pr.yml and the --latest flag on bakery ci matrix.
bschwedler
force-pushed
the
feat/merge-queue-slack-notifications
branch
from
60ad80b to
598914a
Compare
Points bakery-build-pr.yml and setup-bakery (via version:) at feat/merge-queue-slack-notifications so latest-only can be tested before images-shared#576 merges. Once posit-dev/images-shared#576 is merged, drop this commit and restore @main refs in the previous commit.
bschwedler
force-pushed
the
feat/merge-queue-slack-notifications
branch
from
598914a to
62d1082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Slack notification step to the PR workflow that fires when a
merge queue run fails.
The
merge_grouptrigger is required for the workflow to run duringmerge queue checks at all. Without it, the
github.event_name == 'merge_group'condition in the notification step was never satisfied.