fix(connect): warn when TLS verification is disabled#465
Open
tdstein wants to merge 1 commit intofeat/bootstrap-auth-tls-verify-python-settings-content-buildfrom
Open
fix(connect): warn when TLS verification is disabled#465tdstein wants to merge 1 commit intofeat/bootstrap-auth-tls-verify-python-settings-content-buildfrom
tdstein wants to merge 1 commit intofeat/bootstrap-auth-tls-verify-python-settings-content-buildfrom
Conversation
Emit a UserWarning at Client construction time when `verify=False` is passed, to alert users that disabling TLS certificate verification is insecure and should not be used in production. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client(verify=False)silently disabled all TLS certificate validation. This change emits a prominentUserWarningatClientconstruction whenverify is False, recommending a CA bundle path instead.verify is Falseidentity check —verify=Trueand string CA bundle paths are unaffected.Test plan
test_verify_falsewrapped inpytest.warnstest_verify_false_emits_warningtest_verify_true_no_warning+test_verify_ca_bundle_no_warning(usingwarnings.simplefilter("error"))tests/posit/connect/test_client.pypass