fix(connect): prevent URL host confusion in Url join#467
Open
fix(connect): prevent URL host confusion in Url join#467
Conversation
Add a same-origin assertion to the internal _append used by Url, and introduce urls.safe_urljoin() for cases that need explicit urljoin semantics. Both refuse to resolve a fragment to a different scheme/host/port than the configured Connect base URL, defending against user- or server-supplied fragments like "//evil" or "https://evil" that would otherwise escape the base URL. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens URL composition in
posit.connect.urlsso a protocol-relative (//evil/...) or fully-qualified (https://evil/...) path fragment cannot retarget the configured Connect base URL._assert_same_origin(base, resolved)check insideUrl._append— the hot path used by everycfg.url + pathcall in the client. RaisesValueErroron mismatch (scheme, host, or port).safe_urljoin(base, fragment)helper for any future call site that needs urljoin semantics — lstrips leading/, urljoins, then asserts same origin.Url + pathalready routed through_append.Test plan
tests/posit/connect/test_urls.py://evilneutralized (and rejected bysafe_urljoin)https://evilneutralized (and rejected bysafe_urljoin)tests/posit/connect/suite: 356 passed