-
Notifications
You must be signed in to change notification settings - Fork 155
Add support for R breakpoints #11407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
daa20d7
Activate breakpoints for R
lionel- 29335a1
Add `DebugSession::setSessionSuppressToolbar()`
lionel- 1137a39
Switch to permanent DAP session and suppress toolbar when inactive
lionel- 66ec157
Send `SetBreakpoints` on all saves
lionel- c3edc39
Send breakpoints before evaluation when document is dirty
lionel- 0f7a480
Allow verifying breakpoints in dirty documents
lionel- 1bf92bc
Simplify changes needed for verification feature
lionel- 96444b3
Even simpler approach
lionel- e384749
Reconnect DAP immediately to maintain permanent session
lionel- 8537664
Let server drive the reconnection
lionel- 1508dde
Maintain a single DAP connection for all R sessions
lionel- c5c266f
Handle reconnections from the frontend side
lionel- 659a464
Simplify `DapComm` with static factory pattern
lionel- aafe144
Add some logging
lionel- a0d23a8
Delete DAP comm after disposal
lionel- 42cbc67
Debounce `stop_debug` handling
lionel- 4221d8e
Add context key for debug toolbar visibility
lionel- ad14a17
Show welcome view if there is no foreground debug sessions
lionel- 0d9c0d5
Update Welcome view message for R debugger
lionel- a6c58f1
Depend on Ark's breakpoint branch
lionel- 3003c85
Update e2e tests
lionel- f443414
Fix interaction between debug sessions and console history
lionel- 6027773
Do not focus debug pane when a background session comes online
lionel- 8dad315
Adjust test to ensure there is a foreground debug session
lionel- c2a7d0f
Consistently focus debug pane when background session comes to foregr…
lionel- b44fab2
Don't veto exthost restart in case of background debug sessions
lionel- d08b43f
Remove unnecessary getter
lionel- 6885cab
Address code review
lionel- 61d078f
Bump Ark to 0.1.224
lionel- b45c814
More robust call stack tests
lionel- 6d9e321
Disable exthost restart test on Windows
lionel- File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What pulls up the welcome screen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the welcome view but not the streamlined one. I suggested in #10769 (review) to look up the language of the active console when there is no opened editor, to avoid this.