Conversation
Use P3M for extensions
|
E2E Tests 🚀 |
|
@midleman Adding you for the |
|
Note that the verified status still points to OpenVSX because that's what P3M returns on the extension query check. 
|
| "serviceUrl": "https://p3m.dev/openvsx/latest/vscode/gallery", | ||
| "itemUrl": "https://p3m.dev/openvsx/latest/vscode/item", | ||
| "resourceUrlTemplate": "https://p3m.dev/openvsx/latest/vscode/asset/{publisher}/{name}/{version}/Microsoft.VisualStudio.Code.WebResources/{path}", |
There was a problem hiding this comment.
The PR tests are failing with 404s when using this URL to download built in extensions. I see the same thing when I try with curl, but it matches the P3M docs 🤔
There was a problem hiding this comment.
I fixed up the prelaunch extension updates. It didn't use the same URL template.
| }, | ||
| "publisherDisplayName": "charliermarsh", | ||
| "multiPlatformServiceUrl": "https://open-vsx.org/api" | ||
| "multiPlatformServiceUrl": "https://p3m.dev/openvsx/latest/api" |
There was a problem hiding this comment.
| "multiPlatformServiceUrl": "https://p3m.dev/openvsx/latest/api" | |
| "multiPlatformServiceUrl": "https://p3m.dev/openvsx/latest/vscode/asset" |
If we set this to the asset base url could we leave the current implementations of build/lib/bootstrapExtensions.ts and build/lib/extensions.ts as they are?
There was a problem hiding this comment.
From what I tried, it still needs those changes for building the multi-platform download URL. https://p3m.dev/openvsx/latest/vscode/asset/charliermarsh/ruff/darwin-arm64/2026.40.0/file/charliermarsh.ruff-2026.40.0@darwin-arm64.vsix didn't work for me.
There was a problem hiding this comment.
Let me try one more time. I just realized that Ruff currently doesn't publish a Mac version for 2026.40.0.
There was a problem hiding this comment.
I tried https://p3m.dev/openvsx/latest/vscode/asset/charliermarsh/ruff/darwin-arm64/2026.38.0/file/charliermarsh.ruff-2026.38.0@darwin-arm64.vsix and it is an invalid link. The change to the multiPlatformServiceUrl makes sense though. It won't require the gallery replacement.
midleman
left a comment
midleman
left a comment
There was a problem hiding this comment.
Thank you for updating the script! Tried it out, seems to work great for me. 🎉
|
FYI I made some changes in #13097 related to extension checksums. |
|
Looks good for the checksum changes. The changes in |
|
I've updated the other code path for single platform downloads. It now uses the resource template to get the asset. |
4 participants
Address #12875
Updates
product.jsonso that extensions are retrieved from P3M.product.tsupdates the trusted domains but this is for dev builds.The
update-extensions.shscript has also been updated to retrieve bootstrapped extensions from P3M. The response is slightly different than OpenVSX so it has been adjusted and uses the URL templates fromproduct.json.Release Notes
New Features
Bug Fixes
QA Notes