Change runtime session icons#13162
Open
dhruvisompura wants to merge 3 commits intofeature/notebook-sessions-in-quickpickfrom
Open
Change runtime session icons#13162dhruvisompura wants to merge 3 commits intofeature/notebook-sessions-in-quickpickfrom
dhruvisompura wants to merge 3 commits intofeature/notebook-sessions-in-quickpickfrom
Conversation
|
E2E Tests 🚀 |
Contributor
|
lgtm! ty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #11905 and #12741 which added notebook sessions to the interpreter quick pick and the quarto icon to the console tab view.
We received feedback from folks that they didn't like:
To try and address this we've landed on a middle ground: use the file icons that are used in the Explorer pane, breadcrumbs, etc. The file icon themes can be changed but the default one used is called
Seti.The downside to using file icons is that user can change the file icons and override what they see in the interpreter picker, console tab list, and session quick pick. The file icon theme can be changed by searching for "Preferences: File Icon Theme" (
workbench.action.selectIconTheme) in the command palette and picking a different file icon theme. You can see that setting the file icon theme toMinimalorDisabledwill override the icons we show.The only time we show the language pack icons now is when you are selecting a runtime via a quickpick. If you're working with sessions, we use the file icon theme.
The
positronQuartocodicon (codiconsLibrary.ts:763) has no remaining consumers after this PR. I'll remove the registration plus the glyph in a separate cleanup PR.Screenshot
Release Notes
New Features
Bug Fixes
QA Notes
@:interpreter @:sessions @:console @:notebooks @:quarto @:top-action-bar