Update NES LSP server

[georgestagg]

Update's the NES extension's LSP server for https://github.com/posit-dev/posit-ai-supercomplete/pull/66.

Validation Steps

No user facing changes, infrastructure change for new provider.json specification and auth storage location in assistant.

[github-actions]

E2E Tests 🚀
This PR will run tests tagged with: @:critical

Note

No feature tags detected. If this PR needs feature coverage, add the tag above and retrigger the workflow.

^{readme  valid tags}

[sharon-wang]

Swapping @melissa-barca in as reviewer as there's some overlap with #14708!

[melissa-barca]

How come https://github.com/posit-dev/posit-ai-supercomplete/pull/66 is reading providers.json directly instead of importing the new package and relying on loadResolvedProviderCatalog? I'm a bit concerned about Workbench behavior being unintentionally lost if it needs to be implemented in multiple places.

[georgestagg]

How come https://github.com/posit-dev/posit-ai-supercomplete/pull/66 is reading providers.json directly instead of importing the new package and relying on loadResolvedProviderCatalog?

It’s just historical. Before we had the shared package, NES and Assistant implemented reading auth information from the same file separately but with locking, and that separation has survived right up until this point, including reading the new providers.json.

Now that we have the shared package, we could probably migrate NES to that system too. I’m happy to defer the update until that’s been investigated if you prefer.

[melissa-barca]

How come posit-dev/posit-ai-supercomplete#66 is reading providers.json directly instead of importing the new package and relying on loadResolvedProviderCatalog?

It’s just historical. Before we had the shared package, NES and Assistant implemented reading auth information from the same file separately but with locking, and that separation has survived right up until this point, including reading the new providers.json.

Now that we have the shared package, we could probably migrate NES to that system too. I’m happy to defer the update until that’s been investigated if you prefer.

That would be great. The biggest win from implementing that package IMO is that it centralizes all of the settings management logic, and that gets lost if we're reading it directly.