Add provider list to the Configure LLM Providers modal#14879
Closed
bricestacey wants to merge 6 commits into
Closed
Add provider list to the Configure LLM Providers modal#14879bricestacey wants to merge 6 commits into
bricestacey wants to merge 6 commits into
Conversation
|
E2E Tests 🚀 Why these tags?
More on automatic tags from changed files. |
Rework the list to match IMPLEMENTATION_SPEC.md / the assistant-providers prototype: Connected -> Needs Attention -> Model Providers sections (alphabetical), badge-based rows (maturity / Environment / OAuth / Error) with per-section action buttons, a hardcoded provider description map, and an always-present Custom Provider section. Admin-managed mode is deferred. See #14817
- Remove row selection; the per-section action button is the only interactive element (connect/manage flows hang off it, see #14818/#14819). - Wrap each provider icon in a 36x36 rounded square (6px radius, subtle border) per the design. - Add an inline plus icon to the Connect and Add custom provider buttons. See #14817
Contributor
Author
|
:smh: Claude Code is opening PRs willy nilly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14817
Summary
Renders the grouped provider list that is the main content of the new "Configure LLM Providers" modal (epic #14815), following the provider-configuration design spec (
IMPLEMENTATION_SPEC.md/ theassistant-providersprototype). The list is driven off theIPositronLanguageModelSource[]the modal already receives.Sections (alphabetical within each, empty built-in sections hidden):
Each row shows a rounded-square provider avatar (36x36, 6px radius), the provider name, and a maturity badge (Preview / Experimental; none for GA). The per-section action button is the only interactive element - the row itself is not selectable - and the buttons are no-ops for now so the connect flow (#14818) and connected-provider details (#14819) can hang off them later.
Notes on data:
descriptionfield yet, so the "Model Providers" descriptions come from a small hardcoded id->string map mirroring the prototype copy (missing ids render no description).defaults.autoconfigure(Environment) andsupportedOptions(OAuth).visibleProviders) is deferred - Positron has no admin-managed data source wired yet.Behind the hidden
assistant.newProviderModalfeature switch (default off), so no user-visible impact until enabled.Stacked on #14856 (adds the modal shell + feature switch). Based on that branch; retargets to
mainonce #14856 merges.Release Notes
New Features
assistant.newProviderModalswitch)Bug Fixes
Validation Steps
@:assistant
Covered by unit tests:
Manual:
"assistant.newProviderModal": trueinsettings.json.