Skip to content

fix(supervisor): quote space-containing args in PowerShell Start-Process on Windows #14910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samclark2015 merged 1 commit into from
Jul 17, 2026
+9 −2
Merged

fix(supervisor): quote space-containing args in PowerShell Start-Process on Windows #14910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/positron-supervisor/resources/supervisor-wrapper.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ if "%~2"=="" (
)

REM The first argument is the output file; consume it.
set output_file=%1
set "output_file=%~1"
shift

REM `shift` doesn't affect `%*`, so we have to manually remove the first argument
Expand Down
9 changes: 8 additions & 1 deletion extensions/positron-supervisor/src/KallichoreAdapterApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,14 @@ export class KCApi implements PositronSupervisorApi {
wrapperPath = 'powershell.exe';
// Build the arguments for the wrapper script
const escapedWrapper = kernelWrapper.replace(/'/g, "''");
const escapedArgs = shellArgs.map(arg => `'${arg.replace(/'/g, "''")}'`).join(', ');
const escapedArgs = shellArgs.map(arg => {
const escapedArg = arg.replace(/'/g, "''");
// Start-Process joins -ArgumentList elements with spaces when
// building the cmd.exe command line for .bat invocation. Wrap
// args that contain spaces in double-quotes so cmd.exe treats
// them as single tokens.
return arg.includes(' ') ? `'"${escapedArg}"'` : `'${escapedArg}'`;
}).join(', ');
shellArgs = [
'-WindowStyle', 'Hidden',
'-Command',
Expand Down
Loading