feat: sync with latest bslib & r-shiny#2192
Merged
Conversation
Add ggsql language support to prism-code-editor. The grammar file extends SQL with ggsql-specific tokens for visualization queries. Depends on rstudio/bslib#feat/ggsql-language for the grammar source. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cpsievert
changed the title
input_code_editor()
Regenerated by Rscript tools/build_ggsql_grammar.R in bslib. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Port the resizable sidebar feature from bslib (rstudio/bslib#1299). When `resizable=True` (the default), a `data-resizable` attribute is added to the sidebar element, enabling the drag-to-resize handle. Setting `resizable=False` omits the attribute, hiding the handle. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The annotation test requires the express sidebar wrapper to have the same parameters as the core sidebar function. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cpsievert
changed the title
input_code_editor()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR runs
Rscript scripts/htmlDependencies.Rto update to the latest bslib+shiny assets. This is done most immediately in response to rstudio/bslib#1291 in order to enableui.input_code_editor(language="ggsql").Also, while reviewing the changes since the last update, I noticed that rstudio/bslib#1299 needs server-side changes -- these are handled in c4922dc