Upgrade @jupyter-widgets/html-manager from 0.20 to 1.0#237
Open
Upgrade @jupyter-widgets/html-manager from 0.20 to 1.0#237
Conversation
cpsievert
force-pushed
the
upgrade-html-manager-v1
branch
2 times, most recently
from
1f54b38 to
1ad47b1
Compare
3 tasks
Pure style change — no functional difference. This separates the indentation change from the upcoming API signature update, keeping that diff focused on the meaningful changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Upgrade the HTML manager dependency to v1.0.14 (ipywidgets 8.x line). Key changes: - Adapt display_view() / create_view() call signatures to new API - Add get_model() override with async waiter to handle out-of-order comm_open messages (parent model referencing not-yet-registered children) - Replace wildcard `.forward-fill-potential > *` CSS selector with `.forward-fill-potential > .lm-Widget` to avoid sizing transient tooltip siblings - Update static libembed-amd.js bundle and font assets - Add Playwright regression test for ipyleaflet GeoJSON hover Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cpsievert
force-pushed
the
upgrade-html-manager-v1
branch
from
1ad47b1 to
4df64d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@jupyter-widgets/html-managerfrom^0.20.1to^1.0.14(aligns with ipywidgets 8.x)display_view()/create_view()call signatures to the new API (the old shim for the removed dummy first argument is no longer needed)get_model()override with async waiter pattern to handle out-of-ordercomm_openmessages — Shiny delivers these one at a time with microtask breaks, so a parent model's deserialization may reference a child model whosecomm_openhasn't been processed yet.forward-fill-potential > *CSS selector with.forward-fill-potential > .lm-Widgetto avoid giving flex sizing to transient tooltip/overlay siblingslibembed-amd.jsbundle and font assets to match v1.0.14Test plan
make check(format, types, unit tests)make test-playwrightto verify existing + new browser tests pass🤖 Generated with Claude Code