Tests should not fail on existing GEM_HOME/GEM_PATH env variables#18
Open
robfrawley wants to merge 2 commits into
Open
Tests should not fail on existing GEM_HOME/GEM_PATH env variables#18robfrawley wants to merge 2 commits into
robfrawley wants to merge 2 commits into
Conversation
… taken into account and add warning for inconsistantly setting said variables to avoid breaks
…GEM_HOME handling is covered Signed-off-by: Rob Frawley 2nd <rmf@src.run>
Owner
|
I don't see the utility in running the tests with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the push/pop tests to account for the possibility that
GEM_HOMEandGEM_PATHmay be set already in the environment where the tests are being run. Prior, the tests would fail when any values were assigned to theGEM_*variables.A warning was also added for the unsupported state of having a random combination of the
GEM_*variables set and unset: either they must both be assigned a value or neither should be assigned a value, otherwise the tests break. The addition of a large warning makes this clear.Lastly, some additional test environments were added to ensure that everything functions as expected given the environment where no
GEM_*variables are set, as well as the environment where they both are.