Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A core feature of all PowerSync SDKs is the ability to watch select statements for updates. This feature has been missing from the Rust SDK, mostly because I didn't know what the best way to expose it would be: Allocating a result buffer / array is natural in garbage-collected languages, but seems wasteful for Rust.
Instead, this adds
watch_statementas a helper method taking:rusqlite::Paramsto run.The stream then emits the output of the function. This design is quite flexible, e.g. it allows functions to not step through the entire statement if they are only interested in a single row.