Make SyncStatus.toString() more concise
#368
Merged
+77
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevensJourney
approved these changes
Feb 10, 2026
Contributor
stevensJourney
left a comment
stevensJourney
left a comment
There was a problem hiding this comment.
This looks much nicer
Rentacookie
reviewed
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging an issue where we only had logs consisting of
SyncStatuslines, I noticed that the behavior of only writing error messages without any indication on whether they're coming from uploads or downloads is not that helpful. This includes upload and download errors separately, without expandingtoString()output even further when no error is present.This also collapses the
connectedandconnectingstatus into one string field since they can never both be true.