feat: add HTTPS record type (RFC 9460) support#129
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 32 minutes and 41 seconds.Comment |
- Fix ALPN parsing to split comma-separated values per RFC 9460 Section 2.2 - Fix ALPN writing to emit as single comma-separated param (not multiple) - Add HTTPSNoDefault field to domain Record and repository conversions - Add IP hint length validation (error if not multiple of 4/16) - Enforce AliasMode (priority 0) must not have SVCB params
The paramsSize calculation was unused - RDLENGTH is calculated after writing, not pre-calculated. Also use variadic append for ALPN split.
Summary
Changes
TypeHTTPSconstant and HTTPS fields to Record structRFC References
Test plan
go build ./...passesgo test -short ./...passesgo test -v -run HTTPS ./internal/dns/packet/...- 10 tests pass