Skip to content

test(expression): add InExpr edge case tests#51

Merged
poyrazK merged 2 commits intomainfrom
feat/expression-tests
Apr 19, 2026
Merged

test(expression): add InExpr edge case tests#51
poyrazK merged 2 commits intomainfrom
feat/expression-tests

Conversation

@poyrazK
Copy link
Copy Markdown
Owner

@poyrazK poyrazK commented Apr 19, 2026

Summary

  • Add 5 new tests for InExpr edge cases:
    • InExprWithDuplicates: verify duplicates in IN list work correctly
    • InExprWithManyValues: verify IN with 10 values works
    • InExprNotWithManyValues: verify NOT IN with many values
    • InExprWithNullInList: verify NULL in IN list follows SQL semantics
    • InExprEmptyList: verify IN with empty list returns false

Test plan

  • Build and run expression_tests (67 tests pass)

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 19, 2026

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 31 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 20 minutes and 31 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 832f217e-3796-4d52-b94d-ad43ccd100d9

📥 Commits

Reviewing files that changed from the base of the PR and between fef0c80 and a6b3dd4.

📒 Files selected for processing (2)
  • tests/expression_tests.cpp
  • tests/operator_tests.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/expression-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Owner Author

@poyrazK poyrazK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to merge

@poyrazK poyrazK merged commit d174c2d into main Apr 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant