test: improve lock_manager branch coverage to 100%#54
Conversation
Add SharedAcquireAbortedTxn, ExclusiveAcquireAbortedTxn, ExclusiveAcquireTimeout, AlreadyExclusiveReturn, SharedAfterExclusiveSameRID, LockUpgrade tests covering previously untested abort/timeout/upgrade paths.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 22 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
SharedAcquireAbortedTxn— coversacquire_sharedabort path (lines 37-39)ExclusiveAcquireAbortedTxn— coversacquire_exclusiveabort path (lines 90-92)ExclusiveAcquireTimeout— covers timeout path (lines 105-108)AlreadyExclusiveReturn— covers already-held exclusive return (line 73-75)SharedAfterExclusiveSameRID— shared compat after exclusiveLockUpgrade— covers SHARED→EXCLUSIVE upgrade path (line 76)Test plan
make lock_manager_tests && ./lock_manager_tests— 19 tests pass