Skip to content

test: improve branch coverage#71

Merged
poyrazK merged 3 commits intomainfrom
release/branch-coverage-clean
Apr 30, 2026
Merged

test: improve branch coverage#71
poyrazK merged 3 commits intomainfrom
release/branch-coverage-clean

Conversation

@poyrazK
Copy link
Copy Markdown
Owner

@poyrazK poyrazK commented Apr 30, 2026

Summary

  • Add 274 lines of branch coverage tests across 3 test files
  • transaction_manager_tests.cpp: DELETE table not found, UPDATE physical_remove failure, UPDATE undo_remove failure
  • operator_tests.cpp: next_view() branches for ProjectOperator, LimitOperator, FilterOperator
  • query_executor_tests.cpp: batch_insert_mode test

Test plan

  • transaction_manager_tests - 56 tests pass
  • operator_tests - 45 tests pass
  • query_executor_tests - batch_insert_mode test passes

…ery_executor

- transaction_manager: add tests for DELETE table not found, UPDATE
  physical_remove failure, UPDATE undo_remove failure
- operator: add tests for next_view() branches on ProjectOperator,
  LimitOperator, and FilterOperator
- query_executor: add batch_insert_mode test
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

Warning

Rate limit exceeded

@poyrazK has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 30 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c04ae636-8694-4f58-9371-7a68320736bb

📥 Commits

Reviewing files that changed from the base of the PR and between 9fbeea9 and af12d49.

📒 Files selected for processing (3)
  • tests/operator_tests.cpp
  • tests/query_executor_tests.cpp
  • tests/transaction_manager_tests.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/branch-coverage-clean

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 19 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

poyrazK and others added 2 commits April 30, 2026 13:14
Replace exec.execute("ROLLBACK") with tm.abort(txn) + EXPECT_EQ
in UndoUpdatePhysicalRemoveFailure and UndoUpdateUndoRemoveFailure,
matching the pattern fixed in e5e8e73 for the INSERT/DELETE fault tests.

Both tests now verify the transaction reaches ABORTED state after
rollback with fault injection.
Copy link
Copy Markdown
Owner Author

@poyrazK poyrazK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to merge

@poyrazK poyrazK merged commit 2e88938 into main Apr 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant