Conversation
PositionsWriter::build() used unwrap() on u32::try_from() conversions at 4 locations (term_count, doc_count, pos_count, term_bytes.len). These would panic if counts exceeded u32::MAX (~4B), which is effectively impossible but the panic was undocumented. Now uses expect() with descriptive messages documenting the file-format constraint that limits these counts to u32::MAX.
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 53 minutes and 35 seconds.Comment |
1 participant
Summary
unwrap()calls inPositionsWriter::build()withexpect()calls that document the u32::MAX overflow conditionTest plan
cargo test -p cloudsearch-storage— all 35 tests passcargo clippy --package cloudsearch-storage --all-targets— clean