-
Notifications
You must be signed in to change notification settings - Fork 2
feat(instances): enhance stats API with network and disk I/O #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
761c23a
62cd1c8
aed24a4
17bde06
444eb31
122b67d
6f320ab
62e3bc6
2806dc2
5e9d98c
33e6cf9
949aecd
3380c1b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -663,12 +663,24 @@ definitions: | |
| properties: | ||
| cpu_percentage: | ||
| type: number | ||
| cpu_time_nanoseconds: | ||
| description: only populated by Libvirt backend; Docker uses delta-based percentage | ||
| instead | ||
| type: integer | ||
| disk_read_bytes: | ||
| type: integer | ||
| disk_write_bytes: | ||
| type: integer | ||
| memory_limit_bytes: | ||
| type: number | ||
| memory_percentage: | ||
| type: number | ||
| memory_usage_bytes: | ||
| type: number | ||
| network_rx_bytes: | ||
| type: integer | ||
| network_tx_bytes: | ||
| type: integer | ||
|
Comment on lines
+666
to
+683
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result:
Citations:
Specify uint64 format for high-range counters in schema Lines 666-683 define byte/time counters as bare Use 🛠️ Suggested schema patch cpu_time_nanoseconds:
description: only populated by Libvirt backend; Docker uses delta-based percentage
instead
type: integer
+ format: uint64
disk_read_bytes:
type: integer
+ format: uint64
disk_write_bytes:
type: integer
+ format: uint64
@@
network_rx_bytes:
type: integer
+ format: uint64
network_tx_bytes:
type: integer
+ format: uint64🤖 Prompt for AI Agents |
||
| type: object | ||
| domain.InstanceStatus: | ||
| enum: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documented error code does not match actual handler behavior
Line 297 documents
503, but this endpoint currently returns500for internal/backend failures viahttputil.Errordefault mapping. Please align docs with implementation (or implement explicit 503 mapping if that is the intended contract).🤖 Prompt for AI Agents