Conversation
- ovs/adapter.go: validate remoteIP with net.ParseIP in CreateVXLANTunnel and DeleteVXLANTunnel (fixes #255) - instance.go: add iteration limit to findAvailableIP to prevent infinite loop when all IPs in subnet are taken (fixes #262) - instance.go: add overflow check before memory calculation in resize (fixes #263) - dns/powerdns.go: clarify nameserver access after empty check (fixes #258) - docker/snapshot_path.go: add symlink detection to path validation to prevent symlink-based traversal escapes (fixes #239, #238)
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 52 minutes and 13 seconds.Comment |
Summary
Fix 6 input validation issues across 4 files:
repositories/ovs/adapter.go): ValidateremoteIPwithnet.ParseIPinCreateVXLANTunnelandDeleteVXLANTunnel— prevents command injection and malformed IP usage (No validation of remoteIP in OvsAdapter CreateVXLANTunnel and DeleteVXLANTunnel #255)services/instance.go): Add iteration limit tofindAvailableIP— prevents infinite loop when all IPs in subnet are taken (findAvailableIP loops forever when all IPs are taken #262)services/instance.go): Add overflow check before memory calculation in resize path (Integer overflow in CPU and memory calculation for instance types #263)adapters/dns/powerdns.go): Clarify nameserver access after empty check (Potential panic in PowerDNS CreateZone when nameservers slice is empty #258)repositories/docker/snapshot_path.go): Add symlink detection to path validation — prevents symlink-based traversal escapes (Weak path traversal check in docker/adapter.go RestoreVolumeSnapshot #239, Weak path traversal check in docker/adapter.go CreateVolumeSnapshot #238)Test plan
go build ./...go test ./internal/repositories/ovs/... ./internal/core/services/... ./internal/adapters/dns/... ./internal/repositories/docker/... -count=1