Skip to content

fix: add i-- after stream splice in Coordinator.Write (#333)#382

Merged
poyrazK merged 1 commit intomainfrom
fix/coordinator-stream-remove
May 2, 2026
Merged

fix: add i-- after stream splice in Coordinator.Write (#333)#382
poyrazK merged 1 commit intomainfrom
fix/coordinator-stream-remove

Conversation

@poyrazK
Copy link
Copy Markdown
Owner

@poyrazK poyrazK commented May 2, 2026

Summary

  • : add missing after in the Write path
  • Without this, when a stream send fails and the stream is removed, the next element is skipped during broadcast
  • The path at line 469 already had this correctly; only the Write path was broken

Test plan

  • go build ./internal/storage/coordinator/...
  • go vet ./internal/storage/coordinator/...
  • go test -race ./internal/storage/coordinator/... -count=1

Fixes #333

When a stream send fails and the stream is removed from the slice,
the loop must decrement i to correctly reprocess the shifted index.
Without this, the next element is skipped during broadcast.
Copilot AI review requested due to automatic review settings May 2, 2026 19:04
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

Warning

Rate limit exceeded

@poyrazK has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 55 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 403357b4-7176-47ed-bbdd-ba9ee479970e

📥 Commits

Reviewing files that changed from the base of the PR and between c65c38a and 8a946d6.

📒 Files selected for processing (1)
  • internal/storage/coordinator/service.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/coordinator-stream-remove

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 29 minutes and 55 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Owner Author

@poyrazK poyrazK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to merge

@poyrazK poyrazK merged commit d24fa4e into main May 2, 2026
26 checks passed
@poyrazK poyrazK review requested due to automatic review settings May 2, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage coordinator bug: stream removal in loop skips next element

1 participant