Skip to content

fix: close failed gRPC streams, fix libvirt goroutine leak, add io.LimitReader#384

Open
poyrazK wants to merge 1 commit intomainfrom
fix/stream-close-goroutine-leak
Open

fix: close failed gRPC streams, fix libvirt goroutine leak, add io.LimitReader#384
poyrazK wants to merge 1 commit intomainfrom
fix/stream-close-goroutine-leak

Conversation

@poyrazK
Copy link
Copy Markdown
Owner

@poyrazK poyrazK commented May 2, 2026

Summary\n- #330 coordinator/service.go: call stream.CloseAndRecv() before removing failed streams in Write and repairNodes paths\n- #286 libvirt/real_client.go: add ctx.Done and done checks to goroutine errChan send\n- #302 function_handler.go: wrap io.ReadAll with io.LimitReader for code upload (10MB) and invoke payload (1MB)\n\nFixes #330, #286, #302

…mitReader

- coordinator/service.go (#330): call stream.CloseAndRecv() before removing
  failed streams from the slice in Write and repairNodes paths
- libvirt/real_client.go (#286): add ctx.Done and done checks to goroutine
  send to errChan to prevent blocking when context is cancelled
- function_handler.go (#302): wrap io.ReadAll with io.LimitReader for
  code upload (10MB) and invoke payload (1MB)
Copilot AI review requested due to automatic review settings May 2, 2026 19:25
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

Warning

Rate limit exceeded

@poyrazK has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 27 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fb488fe9-72d2-4fbe-afa8-11b10136758c

📥 Commits

Reviewing files that changed from the base of the PR and between cf0fee5 and 83c3263.

📒 Files selected for processing (3)
  • internal/handlers/function_handler.go
  • internal/repositories/libvirt/real_client.go
  • internal/storage/coordinator/service.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/stream-close-goroutine-leak

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 8 minutes and 27 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants