-
Notifications
You must be signed in to change notification settings - Fork 306
Build script for tree sitter python package #7876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
|
@yussufsh PTAL |
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
yussufsh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The get_pkg_version function looks too much like a hack, but it works for us now.
We if want more cleaner approach we can use Setps Get the package version |
| SOURCE=Github | ||
|
|
||
| # Install tree-sitter header | ||
| TREE_SITTER_C_VERSION=v0.24.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we set this to $PACKAGE_VERSION, so that same build-script can be run whenever new upstream version releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we set this val to $PACKAGE_VERSION then we won't be able to build next version which isv0.0.25 of package
As tree-sitter-c latest version is v0.24.1, there is no v0.0.25 in tree-sitter-c
Checklist
set -eoption enabled and observe success ?