Skip to content

Conversation

@adarshagrawal38
Copy link
Contributor

Checklist

  • Have you checked and followed all the points mention in the CONTRIBUTING.MD
  • Have you validated script on UBI 9 container
  • Did you run the script(s) on fresh container with set -e option enabled and observe success ?
  • Did you have Legal approvals for patch files ?

Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
@adarshagrawal38 adarshagrawal38 marked this pull request as ready for review February 9, 2026 04:08
@adarshagrawal38
Copy link
Contributor Author

@yussufsh PTAL

Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
@adarshagrawal38 adarshagrawal38 marked this pull request as draft February 9, 2026 04:56
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
@adarshagrawal38 adarshagrawal38 marked this pull request as ready for review February 10, 2026 12:05
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The get_pkg_version function looks too much like a hack, but it works for us now.

@adarshagrawal38
Copy link
Contributor Author

adarshagrawal38 commented Feb 11, 2026

The get_pkg_version function looks too much like a hack, but it works for us now.

We if want more cleaner approach we can use toml-cli

Setps

cargo install toml-cli
uv lock

Get the package version

[root@711101d41ff1 py-tree-sitter]# toml get uv.lock package | jq -r '.[] | select(.name=="tree-sitter-html") | .version'
0.23.2

SOURCE=Github

# Install tree-sitter header
TREE_SITTER_C_VERSION=v0.24.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set this to $PACKAGE_VERSION, so that same build-script can be run whenever new upstream version releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we set this val to $PACKAGE_VERSION then we won't be able to build next version which isv0.0.25 of package

As tree-sitter-c latest version is v0.24.1, there is no v0.0.25 in tree-sitter-c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants