Tensorflow text 2.18.1 find-links path issue fix #7877
Conversation
smartvibs8876
force-pushed
the
tensorflow-text-2.18.1
branch
from
433dc52 to
6cf6239
Compare
smartvibs8876
force-pushed
the
tensorflow-text-2.18.1
branch
from
6cf6239 to
2db5913
Compare
shubham-dayma-ibm
left a comment
shubham-dayma-ibm
left a comment
There was a problem hiding this comment.
@smartvibs8876 the CI check is failing
| echo "----------bazel installing--------------------" | ||
|
|
||
| # Set to avoid issues with yum installation | ||
| echo "tsflags=nocaps" >> /etc/yum.conf |
There was a problem hiding this comment.
Why are we doing this? Not expecting any change in yum.conf
There was a problem hiding this comment.
One package gstream from yum , was not getting installed so i had added it.
|
|
||
| CURRENT_DIR=$(pwd) | ||
| mkdir -p builder/wheels | ||
| mkdir -p /root/builder/wheels |
There was a problem hiding this comment.
Can't we use $CURRENT_DIR instead of /root/?
There was a problem hiding this comment.
The patch used in script also needs this path, the value of variable CURRENT_DIR cannot be passed to the patch
There was a problem hiding this comment.
Usually we avoid setting running with root privileges. It should be $CURRENT_DIR only.
For patch, you always can print $(pwd) in build-script and look at logs and use it in patch whenever we need it
There was a problem hiding this comment.
Ok I will make this change and push a commit
2 participants
Checklist
set -eoption enabled and observe success ?