Syntax: Add remarks on smallest set, correct some typos#120
Open
szaranczuk wants to merge 1 commit intoppolesiuk:masterfrom
Open
Syntax: Add remarks on smallest set, correct some typos#120szaranczuk wants to merge 1 commit intoppolesiuk:masterfrom
szaranczuk wants to merge 1 commit intoppolesiuk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added some informal clarification of what we really mean by saying "Let A be smallest set satisfying X". I'm not sure how obvious it is to people with background in related topics (for instance those who completed "Metody Programowania" course). I think that the construction of family of indexed sets may be not so intuitive, because in this induction we move from X to X+1 and thus this process does not terminate at a fixed base case. But that construction follows easily, by taking a family that is closed under the proofs of membership.
I also believe that it is just another text about structural induction, and somewhat divergent from the usual way of talking about it. Since I missed the relevant lecture on "Metody Programowania", I am not certain what is covered there, so my remarks may be redundant (or inappropriate).
I've also corrected some typos in chapter 1.