Config: Remove legacy configuration#1206
Open
mkannwischer wants to merge 1 commit into
Open
Conversation
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-44)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (205 proofs)
|
Drop the deprecated MLD_CONFIG_API_* configuration path from the public header. Builds now exclusively use the MLD_CONFIG_* options from the configuration file. Consumers that set the legacy MLD_CONFIG_API_* options directly before including mldsa_native.h should instead configure the build through the configuration file (mldsa_native_config.h, or MLD_CONFIG_FILE), renaming: MLD_CONFIG_API_PARAMETER_SET -> MLD_CONFIG_PARAMETER_SET MLD_CONFIG_API_NAMESPACE_PREFIX -> MLD_CONFIG_NAMESPACE_PREFIX MLD_CONFIG_API_NO_SUPERCOP -> MLD_CONFIG_NO_SUPERCOP MLD_CONFIG_API_CONSTANTS_ONLY -> MLD_CONFIG_CONSTANTS_ONLY MLD_CONFIG_API_QUALIFIER -> MLD_CONFIG_EXTERNAL_API_QUALIFIER For a multi-level build, set MLD_CONFIG_MULTILEVEL_BUILD; the parameter set is now appended to MLD_CONFIG_NAMESPACE_PREFIX automatically and no longer needs to be baked into the prefix. - Resolves #1202 Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
667d83b to
f086e7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the deprecated MLD_CONFIG_API_* configuration path from the public header. Builds now exclusively use the MLD_CONFIG_* options from the configuration file.
Consumers that set the legacy MLD_CONFIG_API_* options directly before including mldsa_native.h should instead configure the build through the configuration file (mldsa_native_config.h, or MLD_CONFIG_FILE), renaming:
MLD_CONFIG_API_PARAMETER_SET -> MLD_CONFIG_PARAMETER_SET
MLD_CONFIG_API_NAMESPACE_PREFIX -> MLD_CONFIG_NAMESPACE_PREFIX
MLD_CONFIG_API_NO_SUPERCOP -> MLD_CONFIG_NO_SUPERCOP
MLD_CONFIG_API_CONSTANTS_ONLY -> MLD_CONFIG_CONSTANTS_ONLY
MLD_CONFIG_API_QUALIFIER -> MLD_CONFIG_EXTERNAL_API_QUALIFIER
For a multi-level build, set MLD_CONFIG_MULTILEVEL_BUILD; the parameter set is now appended to MLD_CONFIG_NAMESPACE_PREFIX automatically and no longer needs to be baked into the prefix.