Skip to content

Document signing secret-key validity precondition #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fegge wants to merge 1 commit into from
+53 −13
Closed

Document signing secret-key validity precondition #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions mldsa/mldsa_native.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,11 @@ int MLD_API_NAMESPACE(keypair)(
* @param prelen Length of prefix string. Ignored when
* externalmu != 0.
* @param[in] rnd Random seed.
* @param[in] sk Bit-packed secret key.
* @param[in] sk Bit-packed valid secret key. Signing does not perform
* full serialized secret-key validation; callers
* importing serialized keys can use
* crypto_sign_pk_from_sk to validate them before
* signing.
* @param externalmu 0: m/mlen is the raw message; mu = H(tr, pre, m) is
* computed internally.
* non-zero: m points to a precomputed mu of
Expand Down Expand Up @@ -361,7 +365,10 @@ int MLD_API_NAMESPACE(signature_internal)(
* @param mlen Length of message.
* @param[in] ctx Pointer to context string. May be NULL if ctxlen == 0.
* @param ctxlen Length of context string. Should be <= 255.
* @param[in] sk Bit-packed secret key.
* @param[in] sk Bit-packed valid secret key. Signing does not perform
* full serialized secret-key validation; callers importing
* serialized keys can use crypto_sign_pk_from_sk to
* validate them before signing.
* @param context Application context. Only present when
* MLD_CONFIG_CONTEXT_PARAMETER is defined; type set by
* MLD_CONFIG_CONTEXT_PARAMETER_TYPE.
Expand Down Expand Up @@ -400,7 +407,10 @@ int MLD_API_NAMESPACE(signature)(
* @param[out] sig Output signature.
* @param[out] siglen Pointer to output length of signature.
* @param[in] mu Precomputed message representative.
* @param[in] sk Bit-packed secret key.
* @param[in] sk Bit-packed valid secret key. Signing does not perform
* full serialized secret-key validation; callers importing
* serialized keys can use crypto_sign_pk_from_sk to
* validate them before signing.
* @param context Application context. Only present when
* MLD_CONFIG_CONTEXT_PARAMETER is defined; type set by
* MLD_CONFIG_CONTEXT_PARAMETER_TYPE.
Expand Down Expand Up @@ -439,7 +449,10 @@ int MLD_API_NAMESPACE(signature_extmu)(
* @param mlen Length of message.
* @param[in] ctx Pointer to context string.
* @param ctxlen Length of context string.
* @param[in] sk Bit-packed secret key.
* @param[in] sk Bit-packed valid secret key. Signing does not perform
* full serialized secret-key validation; callers importing
* serialized keys can use crypto_sign_pk_from_sk to
* validate them before signing.
* @param context Application context. Only present when
* MLD_CONFIG_CONTEXT_PARAMETER is defined; type set by
* MLD_CONFIG_CONTEXT_PARAMETER_TYPE.
Expand Down Expand Up @@ -648,7 +661,10 @@ int MLD_API_NAMESPACE(open)(
* @param[in] ctx Pointer to context string.
* @param ctxlen Length of context string.
* @param[in] rnd Random seed.
* @param[in] sk Bit-packed secret key.
* @param[in] sk Bit-packed valid secret key. Signing does not perform
* full serialized secret-key validation; callers importing
* serialized keys can use crypto_sign_pk_from_sk to
* validate them before signing.
* @param hashalg Hash algorithm constant (one of MLD_PREHASH_*).
* @param context Application context. Only present when
* MLD_CONFIG_CONTEXT_PARAMETER is defined; type set by
Expand Down Expand Up @@ -739,7 +755,10 @@ int MLD_API_NAMESPACE(verify_pre_hash_internal)(
* @param[in] ctx Pointer to context string.
* @param ctxlen Length of context string.
* @param[in] rnd Random seed.
* @param[in] sk Bit-packed secret key.
* @param[in] sk Bit-packed valid secret key. Signing does not perform
* full serialized secret-key validation; callers importing
* serialized keys can use crypto_sign_pk_from_sk to
* validate them before signing.
* @param context Application context. Only present when
* MLD_CONFIG_CONTEXT_PARAMETER is defined; type set by
* MLD_CONFIG_CONTEXT_PARAMETER_TYPE.
Expand Down
30 changes: 24 additions & 6 deletions mldsa/src/sign.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,10 @@ __contract__(
* @param prelen Length of prefix string. Ignored when
* externalmu != 0.
* @param[in] rnd Random seed.
* @param[in] sk Bit-packed secret key.
* @param[in] sk Bit-packed valid secret key. Signing does not perform
* full serialized secret-key validation; callers
* importing serialized keys can use mld_sign_pk_from_sk
* to validate them before signing.
* @param externalmu 0: m/mlen is the raw message; mu = H(tr, pre, m) is
* computed internally.
* non-zero: m points to a precomputed mu of
Expand Down Expand Up @@ -254,7 +257,10 @@ __contract__(
* @param mlen Length of message.
* @param[in] ctx Pointer to context string. May be NULL if ctxlen == 0.
* @param ctxlen Length of context string. Should be <= 255.
* @param[in] sk Bit-packed secret key.
* @param[in] sk Bit-packed valid secret key. Signing does not perform
* full serialized secret-key validation; callers importing
* serialized keys can use mld_sign_pk_from_sk to validate
* them before signing.
* @param context Application context. Only present when
* MLD_CONFIG_CONTEXT_PARAMETER is defined; type set by
* MLD_CONFIG_CONTEXT_PARAMETER_TYPE.
Expand Down Expand Up @@ -303,7 +309,10 @@ __contract__(
* @param[out] sig Output signature.
* @param[out] siglen Pointer to output length of signature.
* @param[in] mu Precomputed message representative.
* @param[in] sk Bit-packed secret key.
* @param[in] sk Bit-packed valid secret key. Signing does not perform
* full serialized secret-key validation; callers importing
* serialized keys can use mld_sign_pk_from_sk to validate
* them before signing.
* @param context Application context. Only present when
* MLD_CONFIG_CONTEXT_PARAMETER is defined; type set by
* MLD_CONFIG_CONTEXT_PARAMETER_TYPE.
Expand Down Expand Up @@ -345,7 +354,10 @@ __contract__(
* @param mlen Length of message.
* @param[in] ctx Pointer to context string.
* @param ctxlen Length of context string.
* @param[in] sk Bit-packed secret key.
* @param[in] sk Bit-packed valid secret key. Signing does not perform
* full serialized secret-key validation; callers importing
* serialized keys can use mld_sign_pk_from_sk to validate
* them before signing.
* @param context Application context. Only present when
* MLD_CONFIG_CONTEXT_PARAMETER is defined; type set by
* MLD_CONFIG_CONTEXT_PARAMETER_TYPE.
Expand Down Expand Up @@ -569,7 +581,10 @@ __contract__(
* @param[in] ctx Pointer to context string.
* @param ctxlen Length of context string.
* @param[in] rnd Random seed.
* @param[in] sk Bit-packed secret key.
* @param[in] sk Bit-packed valid secret key. Signing does not perform
* full serialized secret-key validation; callers importing
* serialized keys can use mld_sign_pk_from_sk to validate
* them before signing.
* @param hashalg Hash algorithm constant (one of MLD_PREHASH_*).
* @param context Application context. Only present when
* MLD_CONFIG_CONTEXT_PARAMETER is defined; type set by
Expand Down Expand Up @@ -674,7 +689,10 @@ __contract__(
* @param[in] ctx Pointer to context string.
* @param ctxlen Length of context string.
* @param[in] rnd Random seed.
* @param[in] sk Bit-packed secret key.
* @param[in] sk Bit-packed valid secret key. Signing does not perform
* full serialized secret-key validation; callers importing
* serialized keys can use mld_sign_pk_from_sk to validate
* them before signing.
* @param context Application context. Only present when
* MLD_CONFIG_CONTEXT_PARAMETER is defined; type set by
* MLD_CONFIG_CONTEXT_PARAMETER_TYPE.
Expand Down
5 changes: 4 additions & 1 deletion test/wycheproof/wycheproof_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,10 @@ class TestResult(Enum):
def check_sign_result(tc, out):
if tc["result"] == "invalid":
flags = tc.get("flags", [])
# InvalidPrivateKey: signing does not validate sk; tested via pk_from_sk
# FIPS 204 does not require signing to validate serialized private keys.
# Checking only s1/s2 would be incomplete: full validation also checks
# t0 and tr and is exposed through pk_from_sk. These InvalidPrivateKey
# vectors are skipped for signing and still tested through pkFromSk.
if "InvalidPrivateKey" in flags:
return TestResult.SKIPPED
# If new invalid-flag classes appear, fail loudly so we can handle them.
Expand Down