Skip to content

Fail HOL-Light tests on unsupported arch#1224

Closed
fegge wants to merge 1 commit into
pq-code-package:mainfrom
trailofbits:fix/hol-light-unsupported-arch-exits-zero
Closed

Fail HOL-Light tests on unsupported arch#1224
fegge wants to merge 1 commit into
pq-code-package:mainfrom
trailofbits:fix/hol-light-unsupported-arch-exits-zero

Conversation

@fegge

@fegge fegge commented Jun 26, 2026

Copy link
Copy Markdown

Summary

  • Make the HOL-Light test command fail on unsupported host architectures instead of reporting success.
  • Keep supported architecture mapping explicit before selecting proof functions.

Validation

  • ruff format scripts/tests: passed
  • ruff check scripts/tests: passed
  • python3 -m py_compile scripts/tests: passed
  • git diff --check -- scripts/tests: passed
  • python3 scripts/tests hol_light --list-functions: passed
  • Unsupported-architecture probe with platform.machine() mocked to riscv64: failed as expected with HOL-Light unsupported architecture: riscv64
  • Not run: ./scripts/format because nixpkgs-fmt is not installed in this local environment
  • Not run: ./scripts/lint because shfmt is not installed in this local environment

Fixes #1214


This work was completed by Trail of Bits as part of the Patch The Planet project in collaboration with OpenAI. The issue was identified primarily by the Codex coding agent, and manually reviewed before submission.

@fegge

fegge commented Jun 26, 2026

Copy link
Copy Markdown
Author

Reopened from an upstream repository branch with DCO-signed commits so full CI can run: #1232

@fegge fegge closed this Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scripts/tests hol_light silently succeeds on unsupported host architectures

1 participant