Skip to content

Reject MLD_PREHASH_NONE in prehash APIs#1228

Open
fegge wants to merge 2 commits into
mainfrom
ptp/prehash-none-message-bypass
Open

Reject MLD_PREHASH_NONE in prehash APIs#1228
fegge wants to merge 2 commits into
mainfrom
ptp/prehash-none-message-bypass

Conversation

@fegge

@fegge fegge commented Jun 26, 2026

Copy link
Copy Markdown

Summary

  • Reject MLD_PREHASH_NONE in the unstable pre-hash signing and verification APIs.
  • Document that MLD_PREHASH_NONE is not supported by these HashML-DSA entry points.
  • Add functional coverage for the rejected pre-hash algorithm.

Validation

  • clang-format -i mldsa/src/sign.c mldsa/src/sign.h mldsa/mldsa_native.h test/src/test_mldsa.c: passed
  • git diff --check -- mldsa/src/sign.c mldsa/src/sign.h mldsa/mldsa_native.h test/src/test_mldsa.c: passed
  • make run_func -j4: passed
  • Not run: ./scripts/format because nixpkgs-fmt is not installed in this local environment
  • Not run: ./scripts/lint because shfmt is not installed in this local environment

Fixes #1215


This work was completed by Trail of Bits as part of the Patch The Planet project in collaboration with OpenAI. The issue was identified primarily by the Codex coding agent, and manually reviewed before submission.

fegge added 2 commits June 26, 2026 18:17
Signed-off-by: Fredrik Dahlgren <fredrik.dahlgren@trailofbits.com>
Signed-off-by: Fredrik Dahlgren <fredrik.dahlgren@trailofbits.com>
@oqs-bot

oqs-bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

CBMC Results (ML-DSA-65, REDUCE-RAM)

Full Results (205 proofs)
Proof Status Current Previous Change
**TOTAL** 2047s 1970s +3.9%
polyvec_matrix_pointwise_montgomery_yvec 205s 192s +7%
mld_ct_memcmp 189s 180s +5%
mld_invntt_layer 186s 174s +7%
rej_uniform_native 174s 165s +5%
poly_pointwise_montgomery_c 122s 117s +4%
rej_uniform_native_aarch64 113s 112s +1%
sign_verify_internal 70s 71s -1%
mld_ntt_layer 44s 42s +5%
polyvecl_chknorm 42s 38s +11%
fqmul 39s 40s -3%
polyveck_chknorm 33s 32s +3%
mld_attempt_signature_generation 28s 26s +8%
mld_ntt_butterfly_block 23s 20s +15%
keccakf1600x4_permute_native 21s 25s -16%
poly_ntt_c 21s 18s +17%
mld_check_pct 15s 14s +7%
rej_uniform_c 14s 14s +0%
polyt0_unpack 12s 10s +20%
keccak_absorb_once_x4 11s 9s +22%
poly_uniform_eta_4x 11s 13s -15%
polyveck_decompose 11s 13s -15%
poly_chknorm_c 10s 12s -17%
poly_invntt_tomont_c 10s 12s -17%
sign 9s 10s -10%
compute_pack_t0_t1 8s 7s +14%
mld_compute_pack_z 8s 7s +14%
polyvec_matrix_pointwise_montgomery_row 8s 10s -20%
polyveck_reduce 8s 6s +33%
polyz_unpack_c 8s 10s -20%
mld_keccakf1600_permute_c 7s 7s +0%
polyveck_caddq 7s 5s +40%
polyvecl_ntt 7s 6s +17%
rej_uniform 7s 8s -12%
sign_open 7s 5s +40%
sign_pk_from_sk 7s 8s -12%
mld_sample_s1_s2 6s 5s +20%
mld_sample_s1_s2_serial 6s 6s +0%
pointwise_acc_native_x86_64 6s 7s -14%
poly_chknorm_native_aarch64 6s 2s +200%
poly_reduce 6s 4s +50%
sign_keypair 6s 4s +50%
intt_native_x86_64 5s 3s +67%
mld_ct_cmask_nonzero_u8 5s 1s +400%
mld_keccakf1600_extract_bytes 5s 1s +400%
mld_polymat_expand_entry 5s 2s +150%
mld_prepare_domain_separation_prefix 5s 5s +0%
ntt_native_x86_64 5s 2s +150%
pointwise_acc_native_aarch64 5s 6s -17%
pointwise_native_x86_64 5s 4s +25%
poly_add 5s 5s +0%
poly_caddq_c 5s 5s +0%
poly_challenge 5s 3s +67%
poly_decompose_c 5s 13s -62%
poly_pointwise_montgomery_native 5s 5s +0%
poly_power2round 5s 3s +67%
poly_uniform_eta 5s 2s +150%
polyveck_invntt_tomont 5s 7s -29%
polyz_unpack 5s 3s +67%
rej_uniform_eta_native_aarch64 5s 3s +67%
sign_keypair_internal 5s 6s -17%
sign_verify 5s 4s +25%
sign_verify_pre_hash_shake256 5s 4s +25%
unpack_sk_t0hat 5s 5s +0%
caddq 4s 3s +33%
decompose 4s 3s +33%
fqscale 4s 3s +33%
intt_native_aarch64 4s 2s +100%
keccak_absorb 4s 2s +100%
keccak_f1600_x1_native_aarch64_v84a 4s 2s +100%
keccakf1600_permute_native 4s 2s +100%
keccakf1600_xor_bytes 4s 2s +100%
mld_keccakf1600x4_xor_bytes_c 4s 1s +300%
montgomery_reduce 4s 2s +100%
pointwise_native_aarch64 4s 3s +33%
poly_caddq 4s 4s +0%
poly_caddq_native_x86_64 4s 3s +33%
poly_chknorm 4s 3s +33%
poly_decompose_32_native_aarch64 4s 3s +33%
poly_invntt_tomont 4s 5s -20%
poly_invntt_tomont_native 4s 3s +33%
poly_ntt 4s 3s +33%
poly_ntt_native 4s 3s +33%
poly_pointwise_montgomery 4s 3s +33%
poly_uniform 4s 4s +0%
poly_uniform_gamma1 4s 3s +33%
poly_use_hint_native 4s 4s +0%
polyvecl_pointwise_acc_montgomery_c 4s 3s +33%
polyvecl_pointwise_acc_montgomery_native 4s 4s +0%
polyvecl_uniform_gamma1_serial 4s 5s -20%
polyw1_pack_88 4s 5s -20%
polyz_unpack_17_native_aarch64 4s 1s +300%
polyz_unpack_19_native_aarch64 4s 4s +0%
rej_eta_c 4s 3s +33%
shake128_init 4s 2s +100%
shake128x4_absorb_once 4s 4s +0%
sign_signature 4s 3s +33%
sign_signature_extmu 4s 4s +0%
sign_signature_internal 4s 6s -33%
sign_signature_pre_hash_internal 4s 5s -20%
sys_check_capability 4s 2s +100%
yvec_init 4s 3s +33%
keccak_f1600_x4_native_avx2 3s 2s +50%
keccak_init 3s 4s -25%
keccakf1600_xor_bytes (big endian) 3s 2s +50%
keccakf1600x4_permute 3s 4s -25%
keccakf1600x4_xor_bytes_native 3s 3s +0%
make_hint 3s 3s +0%
mld_ct_cmask_neg_i32 3s 3s +0%
mld_ct_cmask_nonzero_u32 3s 2s +50%
mld_ct_get_optblocker_u8 3s 2s +50%
mld_h 3s 4s -25%
mld_value_barrier_i64 3s 4s -25%
mld_value_barrier_u8 3s 2s +50%
nttunpack_native_x86_64 3s 5s -40%
pack_sig_c 3s 3s +0%
pack_sig_z 3s 2s +50%
pack_sk_rho_key_tr_s2 3s 5s -40%
pack_sk_s1 3s 4s -25%
poly_caddq_native_aarch64 3s 2s +50%
poly_chknorm_native 3s 3s +0%
poly_chknorm_native_x86_64 3s 3s +0%
poly_decompose_88_native_aarch64 3s 2s +50%
poly_decompose_native 3s 5s -40%
poly_permute_bitrev_to_custom_optional 3s 2s +50%
poly_shiftl 3s 5s -40%
poly_uniform_4x 3s 2s +50%
poly_use_hint 3s 2s +50%
poly_use_hint_native_aarch64 3s 5s -40%
polyeta_pack 3s 2s +50%
polyt0_pack 3s 5s -40%
polyt1_pack 3s 3s +0%
polyvec_matrix_expand 3s 2s +50%
polyvec_matrix_expand_serial 3s 2s +50%
polyveck_pack_eta 3s 1s +200%
polyveck_pack_w1 3s 3s +0%
polyvecl_pack_eta 3s 3s +0%
polyvecl_unpack_eta 3s 2s +50%
polyw1_pack_32 3s 3s +0%
polyz_unpack_native 3s 3s +0%
polyz_unpack_native_x86_64 3s 2s +50%
power2round 3s 3s +0%
reduce32 3s 2s +50%
rej_eta 3s 3s +0%
rej_eta_native 3s 3s +0%
shake128_finalize 3s 2s +50%
shake128x4_squeezeblocks 3s 3s +0%
shake256_absorb 3s 2s +50%
shake256_finalize 3s 3s +0%
shake256x4_squeezeblocks 3s 3s +0%
sign_signature_pre_hash_shake256 3s 5s -40%
sign_verify_pre_hash_internal 3s 4s -25%
sk_s1hat_get_poly 3s 3s +0%
unpack_pk_t1 3s 3s +0%
unpack_sk_s1hat 3s 2s +50%
use_hint 3s 3s +0%
yvec_get_poly 3s 1s +200%
keccak_f1600_x1_native_aarch64 2s 1s +100%
keccak_f1600_x4_native_aarch64_v84a 2s 3s -33%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 2s 2s +0%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 2s 3s -33%
keccak_squeeze 2s 3s -33%
keccak_squeezeblocks_x4 2s 4s -50%
keccakf1600_permute 2s 2s +0%
keccakf1600x4_extract_bytes 2s 3s -33%
keccakf1600x4_extract_bytes_native 2s 2s +0%
keccakf1600x4_xor_bytes 2s 3s -33%
mld_ct_abs_i32 2s 2s +0%
mld_ct_get_optblocker_u32 2s 1s +100%
mld_ct_sel_int32 2s 3s -33%
mld_keccakf1600x4_extract_bytes_c 2s 3s -33%
mld_value_barrier_u32 2s 2s +0%
ntt_native_aarch64 2s 3s -33%
pack_sig_h 2s 4s -50%
poly_caddq_native 2s 4s -50%
poly_permute_bitrev_to_custom_optional_native 2s 4s -50%
poly_uniform_gamma1_4x 2s 2s +0%
polyt1_unpack 2s 2s +0%
polyveck_ntt 2s 3s -33%
polyveck_unpack_eta 2s 3s -33%
polyvecl_pointwise_acc_montgomery 2s 3s -33%
polyvecl_uniform_gamma1 2s 5s -60%
polyvecl_unpack_z 2s 4s -50%
polyw1_pack 2s 4s -50%
polyz_pack 2s 2s +0%
shake128_absorb 2s 4s -50%
shake128_squeeze 2s 2s +0%
shake256 2s 1s +100%
shake256_init 2s 5s -60%
shake256_release 2s 2s +0%
shake256_squeeze 2s 2s +0%
sig_unpack_hints 2s 3s -33%
sign_verify_extmu 2s 4s -50%
sk_s2hat_get_poly 2s 3s -33%
sk_t0hat_get_poly 2s 3s -33%
unpack_sk 2s 2s +0%
unpack_sk_s2hat 2s 1s +100%
keccak_finalize 1s 3s -67%
keccakf1600_extract_bytes (big endian) 1s 2s -50%
mld_ct_get_optblocker_i64 1s 2s -50%
poly_decompose 1s 4s -75%
poly_sub 1s 3s -67%
poly_use_hint_c 1s 1s +0%
polyeta_unpack 1s 1s +0%
shake128_release 1s 1s +0%
shake256x4_absorb_once 1s 2s -50%

@oqs-bot

oqs-bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

CBMC Results (ML-DSA-44, REDUCE-RAM)

Full Results (205 proofs)
Proof Status Current Previous Change
**TOTAL** 1998s 2080s -3.9%
mld_ct_memcmp 200s 204s -2%
mld_invntt_layer 192s 197s -3%
rej_uniform_native 176s 189s -7%
polyvec_matrix_pointwise_montgomery_yvec 152s 159s -4%
poly_pointwise_montgomery_c 134s 135s -1%
rej_uniform_native_aarch64 119s 118s +1%
polyveck_chknorm 69s 70s -1%
sign_verify_internal 54s 57s -5%
mld_ntt_layer 45s 49s -8%
fqmul 43s 44s -2%
mld_attempt_signature_generation 26s 25s +4%
keccakf1600x4_permute_native 23s 20s +15%
mld_ntt_butterfly_block 23s 27s -15%
poly_ntt_c 21s 22s -5%
rej_uniform_c 16s 16s +0%
compute_pack_t0_t1 14s 11s +27%
mld_check_pct 14s 16s -12%
polyeta_unpack 14s 14s +0%
poly_chknorm_c 12s 14s -14%
poly_invntt_tomont_c 12s 11s +9%
poly_uniform_eta_4x 12s 15s -20%
polyvecl_chknorm 12s 13s -8%
polyt0_unpack 11s 13s -15%
polyz_unpack_c 10s 10s +0%
polyveck_decompose 9s 8s +12%
keccak_absorb_once_x4 8s 9s -11%
rej_uniform 8s 7s +14%
sign_pk_from_sk 8s 8s +0%
polyvec_matrix_pointwise_montgomery_row 7s 6s +17%
sign 7s 10s -30%
keccak_absorb 6s 3s +100%
mld_compute_pack_z 6s 7s -14%
pointwise_acc_native_aarch64 6s 5s +20%
pointwise_acc_native_x86_64 6s 6s +0%
poly_add 6s 7s -14%
poly_permute_bitrev_to_custom_optional 6s 3s +100%
poly_reduce 6s 8s -25%
polyz_unpack_17_native_aarch64 6s 6s +0%
rej_eta_native 6s 5s +20%
sign_signature_extmu 6s 6s +0%
sign_signature_pre_hash_internal 6s 3s +100%
intt_native_x86_64 5s 3s +67%
mld_keccakf1600_extract_bytes 5s 3s +67%
mld_keccakf1600_permute_c 5s 10s -50%
poly_challenge 5s 5s +0%
poly_power2round 5s 6s -17%
polyt1_unpack 5s 4s +25%
polyveck_caddq 5s 3s +67%
polyvecl_ntt 5s 3s +67%
polyvecl_pack_eta 5s 2s +150%
polyw1_pack_32 5s 2s +150%
sign_keypair 5s 6s -17%
sign_signature_internal 5s 6s -17%
caddq 4s 2s +100%
fqscale 4s 4s +0%
mld_ct_abs_i32 4s 3s +33%
mld_prepare_domain_separation_prefix 4s 7s -43%
mld_sample_s1_s2_serial 4s 6s -33%
pack_sig_h 4s 3s +33%
pointwise_native_aarch64 4s 3s +33%
pointwise_native_x86_64 4s 3s +33%
poly_caddq_native 4s 5s -20%
poly_caddq_native_x86_64 4s 3s +33%
poly_decompose_32_native_aarch64 4s 2s +100%
poly_decompose_c 4s 6s -33%
poly_invntt_tomont 4s 1s +300%
poly_ntt_native 4s 2s +100%
poly_shiftl 4s 5s -20%
poly_uniform_eta 4s 5s -20%
polyveck_ntt 4s 3s +33%
polyveck_reduce 4s 4s +0%
polyvecl_unpack_eta 4s 2s +100%
polyw1_pack_88 4s 2s +100%
polyz_unpack_19_native_aarch64 4s 3s +33%
power2round 4s 3s +33%
reduce32 4s 2s +100%
rej_uniform_eta_native_aarch64 4s 3s +33%
shake256 4s 3s +33%
sign_open 4s 6s -33%
sign_signature_pre_hash_shake256 4s 4s +0%
sign_verify 4s 2s +100%
sign_verify_pre_hash_internal 4s 3s +33%
sign_verify_pre_hash_shake256 4s 3s +33%
sk_s2hat_get_poly 4s 2s +100%
sys_check_capability 4s 4s +0%
unpack_pk_t1 4s 2s +100%
yvec_get_poly 4s 2s +100%
intt_native_aarch64 3s 3s +0%
keccak_f1600_x4_native_aarch64_v84a 3s 2s +50%
keccak_init 3s 3s +0%
keccak_squeeze 3s 3s +0%
keccakf1600_extract_bytes (big endian) 3s 4s -25%
keccakf1600_permute 3s 3s +0%
keccakf1600_permute_native 3s 2s +50%
keccakf1600_xor_bytes 3s 2s +50%
keccakf1600x4_extract_bytes_native 3s 2s +50%
keccakf1600x4_permute 3s 1s +200%
keccakf1600x4_xor_bytes_native 3s 1s +200%
mld_ct_cmask_nonzero_u8 3s 4s -25%
mld_ct_get_optblocker_i64 3s 1s +200%
mld_ct_get_optblocker_u8 3s 2s +50%
mld_ct_sel_int32 3s 2s +50%
mld_polymat_expand_entry 3s 4s -25%
ntt_native_x86_64 3s 4s -25%
pack_sk_rho_key_tr_s2 3s 5s -40%
pack_sk_s1 3s 3s +0%
poly_caddq 3s 3s +0%
poly_caddq_c 3s 5s -40%
poly_caddq_native_aarch64 3s 3s +0%
poly_chknorm 3s 2s +50%
poly_decompose_88_native_aarch64 3s 3s +0%
poly_invntt_tomont_native 3s 3s +0%
poly_permute_bitrev_to_custom_optional_native 3s 2s +50%
poly_uniform 3s 5s -40%
poly_uniform_4x 3s 4s -25%
poly_uniform_gamma1 3s 4s -25%
poly_use_hint_c 3s 4s -25%
poly_use_hint_native 3s 5s -40%
poly_use_hint_native_aarch64 3s 4s -25%
polyeta_pack 3s 2s +50%
polyt0_pack 3s 6s -50%
polyvec_matrix_expand 3s 3s +0%
polyveck_pack_eta 3s 2s +50%
polyveck_unpack_eta 3s 2s +50%
polyvecl_pointwise_acc_montgomery 3s 2s +50%
polyvecl_uniform_gamma1 3s 3s +0%
polyvecl_uniform_gamma1_serial 3s 1s +200%
polyw1_pack 3s 4s -25%
polyz_pack 3s 3s +0%
polyz_unpack 3s 3s +0%
polyz_unpack_native_x86_64 3s 5s -40%
rej_eta 3s 3s +0%
shake128_release 3s 3s +0%
shake128x4_absorb_once 3s 2s +50%
shake128x4_squeezeblocks 3s 3s +0%
shake256_squeeze 3s 2s +50%
shake256x4_absorb_once 3s 3s +0%
sig_unpack_hints 3s 2s +50%
sign_keypair_internal 3s 7s -57%
sign_verify_extmu 3s 3s +0%
sk_t0hat_get_poly 3s 2s +50%
unpack_sk_s1hat 3s 5s -40%
unpack_sk_s2hat 3s 2s +50%
yvec_init 3s 2s +50%
decompose 2s 3s -33%
keccak_f1600_x1_native_aarch64 2s 2s +0%
keccak_f1600_x1_native_aarch64_v84a 2s 1s +100%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 2s 3s -33%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 2s 3s -33%
keccak_f1600_x4_native_avx2 2s 2s +0%
keccak_finalize 2s 1s +100%
keccak_squeezeblocks_x4 2s 5s -60%
keccakf1600_xor_bytes (big endian) 2s 3s -33%
keccakf1600x4_extract_bytes 2s 3s -33%
keccakf1600x4_xor_bytes 2s 1s +100%
make_hint 2s 4s -50%
mld_ct_cmask_neg_i32 2s 3s -33%
mld_ct_cmask_nonzero_u32 2s 2s +0%
mld_ct_get_optblocker_u32 2s 2s +0%
mld_h 2s 2s +0%
mld_keccakf1600x4_extract_bytes_c 2s 2s +0%
mld_keccakf1600x4_xor_bytes_c 2s 2s +0%
mld_sample_s1_s2 2s 6s -67%
mld_value_barrier_i64 2s 2s +0%
mld_value_barrier_u32 2s 2s +0%
ntt_native_aarch64 2s 3s -33%
nttunpack_native_x86_64 2s 3s -33%
pack_sig_z 2s 4s -50%
poly_chknorm_native_aarch64 2s 3s -33%
poly_chknorm_native_x86_64 2s 3s -33%
poly_decompose_native 2s 4s -50%
poly_ntt 2s 1s +100%
poly_pointwise_montgomery 2s 4s -50%
poly_pointwise_montgomery_native 2s 5s -60%
poly_sub 2s 3s -33%
poly_uniform_gamma1_4x 2s 4s -50%
polyt1_pack 2s 6s -67%
polyvec_matrix_expand_serial 2s 3s -33%
polyveck_pack_w1 2s 5s -60%
polyvecl_pointwise_acc_montgomery_c 2s 2s +0%
polyvecl_pointwise_acc_montgomery_native 2s 5s -60%
polyvecl_unpack_z 2s 3s -33%
polyz_unpack_native 2s 2s +0%
rej_eta_c 2s 3s -33%
shake128_absorb 2s 3s -33%
shake128_init 2s 2s +0%
shake128_squeeze 2s 5s -60%
shake256_absorb 2s 3s -33%
shake256_finalize 2s 3s -33%
shake256_init 2s 1s +100%
shake256_release 2s 3s -33%
shake256x4_squeezeblocks 2s 3s -33%
sign_signature 2s 5s -60%
sk_s1hat_get_poly 2s 3s -33%
unpack_sk 2s 2s +0%
unpack_sk_t0hat 2s 3s -33%
use_hint 2s 2s +0%
mld_value_barrier_u8 1s 3s -67%
montgomery_reduce 1s 4s -75%
pack_sig_c 1s 2s -50%
poly_chknorm_native 1s 3s -67%
poly_decompose 1s 4s -75%
poly_use_hint 1s 4s -75%
polyveck_invntt_tomont 1s 4s -75%
shake128_finalize 1s 3s -67%

@oqs-bot

oqs-bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

CBMC Results (ML-DSA-87, REDUCE-RAM)

Full Results (205 proofs)
Proof Status Current Previous Change
**TOTAL** 2027s 2167s -6.5%
polyvec_matrix_pointwise_montgomery_yvec 198s 213s -7%
mld_ct_memcmp 189s 214s -12%
mld_invntt_layer 183s 200s -8%
rej_uniform_native 182s 189s -4%
poly_pointwise_montgomery_c 137s 147s -7%
rej_uniform_native_aarch64 113s 119s -5%
sign_verify_internal 49s 50s -2%
fqmul 45s 45s +0%
mld_ntt_layer 44s 47s -6%
polyvecl_chknorm 35s 38s -8%
mld_attempt_signature_generation 32s 32s +0%
mld_ntt_butterfly_block 25s 25s +0%
keccakf1600x4_permute_native 23s 22s +5%
mld_check_pct 18s 16s +12%
poly_ntt_c 18s 22s -18%
rej_uniform_c 16s 18s -11%
poly_chknorm_c 14s 13s +8%
polyeta_unpack 14s 15s -7%
compute_pack_t0_t1 13s 13s +0%
poly_invntt_tomont_c 12s 12s +0%
poly_uniform_eta_4x 11s 13s -15%
polyt0_unpack 11s 12s -8%
polyvec_matrix_pointwise_montgomery_row 11s 13s -15%
polyveck_decompose 11s 12s -8%
keccak_absorb_once_x4 9s 10s -10%
polyveck_chknorm 9s 11s -18%
polyz_unpack_c 9s 7s +29%
rej_uniform 9s 7s +29%
sign 9s 8s +12%
pointwise_acc_native_x86_64 8s 8s +0%
polyvecl_ntt 8s 9s -11%
mld_sample_s1_s2 7s 7s +0%
mld_sample_s1_s2_serial 7s 5s +40%
pointwise_acc_native_aarch64 7s 8s -12%
sign_keypair_internal 7s 7s +0%
sign_pk_from_sk 7s 6s +17%
sign_signature_internal 7s 6s +17%
keccakf1600_permute_native 6s 4s +50%
keccakf1600x4_extract_bytes_native 6s 4s +50%
mld_keccakf1600_permute_c 6s 6s +0%
poly_add 6s 6s +0%
poly_caddq_native 6s 6s +0%
sign_verify_pre_hash_shake256 6s 3s +100%
unpack_sk_s2hat 6s 2s +200%
fqscale 5s 4s +25%
intt_native_aarch64 5s 3s +67%
mld_prepare_domain_separation_prefix 5s 3s +67%
poly_challenge 5s 4s +25%
poly_decompose_88_native_aarch64 5s 4s +25%
poly_power2round 5s 5s +0%
poly_reduce 5s 5s +0%
poly_sub 5s 2s +150%
poly_uniform_4x 5s 2s +150%
poly_uniform_gamma1 5s 5s +0%
polyveck_caddq 5s 7s -29%
polyveck_reduce 5s 9s -44%
polyw1_pack_32 5s 2s +150%
shake128x4_absorb_once 5s 2s +150%
sign_open 5s 6s -17%
sign_verify_pre_hash_internal 5s 4s +25%
sys_check_capability 5s 3s +67%
unpack_pk_t1 5s 3s +67%
keccak_squeeze 4s 4s +0%
keccak_squeezeblocks_x4 4s 8s -50%
keccakf1600_extract_bytes (big endian) 4s 2s +100%
keccakf1600_xor_bytes 4s 3s +33%
mld_compute_pack_z 4s 6s -33%
mld_h 4s 5s -20%
ntt_native_aarch64 4s 2s +100%
nttunpack_native_x86_64 4s 2s +100%
pack_sig_z 4s 2s +100%
pack_sk_rho_key_tr_s2 4s 3s +33%
poly_caddq_c 4s 5s -20%
poly_caddq_native_x86_64 4s 3s +33%
poly_decompose 4s 3s +33%
poly_decompose_32_native_aarch64 4s 3s +33%
poly_decompose_c 4s 5s -20%
poly_use_hint_c 4s 3s +33%
poly_use_hint_native_aarch64 4s 3s +33%
polyt0_pack 4s 5s -20%
polyt1_unpack 4s 4s +0%
polyveck_invntt_tomont 4s 6s -33%
polyvecl_unpack_z 4s 4s +0%
polyz_unpack_19_native_aarch64 4s 3s +33%
polyz_unpack_native 4s 4s +0%
rej_uniform_eta_native_aarch64 4s 6s -33%
shake256_init 4s 3s +33%
sign_keypair 4s 5s -20%
sign_signature 4s 6s -33%
sign_signature_pre_hash_internal 4s 3s +33%
sign_verify_extmu 4s 5s -20%
sk_s1hat_get_poly 4s 4s +0%
unpack_sk_t0hat 4s 3s +33%
decompose 3s 5s -40%
intt_native_x86_64 3s 3s +0%
keccak_f1600_x1_native_aarch64 3s 2s +50%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 3s 2s +50%
keccak_f1600_x4_native_avx2 3s 2s +50%
keccak_finalize 3s 2s +50%
keccakf1600_permute 3s 4s -25%
keccakf1600_xor_bytes (big endian) 3s 3s +0%
keccakf1600x4_extract_bytes 3s 2s +50%
make_hint 3s 3s +0%
mld_ct_abs_i32 3s 2s +50%
mld_ct_sel_int32 3s 4s -25%
mld_polymat_expand_entry 3s 3s +0%
ntt_native_x86_64 3s 3s +0%
pack_sig_h 3s 4s -25%
poly_caddq 3s 3s +0%
poly_caddq_native_aarch64 3s 2s +50%
poly_chknorm 3s 3s +0%
poly_chknorm_native 3s 2s +50%
poly_chknorm_native_aarch64 3s 3s +0%
poly_chknorm_native_x86_64 3s 2s +50%
poly_decompose_native 3s 3s +0%
poly_invntt_tomont 3s 2s +50%
poly_ntt 3s 3s +0%
poly_pointwise_montgomery 3s 3s +0%
poly_pointwise_montgomery_native 3s 4s -25%
poly_uniform 3s 5s -40%
poly_uniform_gamma1_4x 3s 3s +0%
poly_use_hint 3s 3s +0%
polyeta_pack 3s 2s +50%
polyvec_matrix_expand 3s 3s +0%
polyveck_ntt 3s 6s -50%
polyveck_pack_eta 3s 4s -25%
polyvecl_pointwise_acc_montgomery 3s 3s +0%
polyvecl_pointwise_acc_montgomery_c 3s 1s +200%
polyvecl_pointwise_acc_montgomery_native 3s 4s -25%
polyvecl_uniform_gamma1 3s 7s -57%
polyvecl_uniform_gamma1_serial 3s 2s +50%
polyw1_pack 3s 2s +50%
polyw1_pack_88 3s 3s +0%
polyz_unpack 3s 3s +0%
polyz_unpack_17_native_aarch64 3s 4s -25%
rej_eta_native 3s 4s -25%
shake128_release 3s 5s -40%
shake128_squeeze 3s 2s +50%
shake256_release 3s 3s +0%
shake256x4_absorb_once 3s 3s +0%
sig_unpack_hints 3s 2s +50%
sign_signature_extmu 3s 4s -25%
sign_verify 3s 2s +50%
sk_t0hat_get_poly 3s 3s +0%
unpack_sk_s1hat 3s 3s +0%
yvec_get_poly 3s 3s +0%
yvec_init 3s 3s +0%
caddq 2s 3s -33%
keccak_absorb 2s 4s -50%
keccak_f1600_x4_native_aarch64_v84a 2s 2s +0%
keccak_init 2s 3s -33%
keccakf1600x4_permute 2s 3s -33%
keccakf1600x4_xor_bytes 2s 2s +0%
mld_ct_cmask_neg_i32 2s 2s +0%
mld_ct_cmask_nonzero_u8 2s 2s +0%
mld_ct_get_optblocker_u8 2s 2s +0%
mld_keccakf1600_extract_bytes 2s 3s -33%
mld_keccakf1600x4_extract_bytes_c 2s 3s -33%
mld_keccakf1600x4_xor_bytes_c 2s 4s -50%
mld_value_barrier_i64 2s 1s +100%
mld_value_barrier_u32 2s 2s +0%
montgomery_reduce 2s 1s +100%
pack_sk_s1 2s 3s -33%
pointwise_native_aarch64 2s 3s -33%
pointwise_native_x86_64 2s 2s +0%
poly_invntt_tomont_native 2s 4s -50%
poly_ntt_native 2s 3s -33%
poly_permute_bitrev_to_custom_optional 2s 2s +0%
poly_permute_bitrev_to_custom_optional_native 2s 4s -50%
poly_uniform_eta 2s 3s -33%
poly_use_hint_native 2s 5s -60%
polyt1_pack 2s 4s -50%
polyvec_matrix_expand_serial 2s 3s -33%
polyveck_pack_w1 2s 3s -33%
polyveck_unpack_eta 2s 3s -33%
polyvecl_pack_eta 2s 3s -33%
polyz_pack 2s 3s -33%
polyz_unpack_native_x86_64 2s 3s -33%
power2round 2s 6s -67%
reduce32 2s 3s -33%
rej_eta 2s 3s -33%
rej_eta_c 2s 3s -33%
shake128_finalize 2s 4s -50%
shake256 2s 2s +0%
shake256_finalize 2s 3s -33%
shake256_squeeze 2s 4s -50%
shake256x4_squeezeblocks 2s 2s +0%
sign_signature_pre_hash_shake256 2s 7s -71%
sk_s2hat_get_poly 2s 3s -33%
unpack_sk 2s 3s -33%
use_hint 2s 2s +0%
keccak_f1600_x1_native_aarch64_v84a 1s 1s +0%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 1s 1s +0%
keccakf1600x4_xor_bytes_native 1s 3s -67%
mld_ct_cmask_nonzero_u32 1s 4s -75%
mld_ct_get_optblocker_i64 1s 4s -75%
mld_ct_get_optblocker_u32 1s 3s -67%
mld_value_barrier_u8 1s 4s -75%
pack_sig_c 1s 3s -67%
poly_shiftl 1s 4s -75%
polyvecl_unpack_eta 1s 3s -67%
shake128_absorb 1s 3s -67%
shake128_init 1s 5s -80%
shake128x4_squeezeblocks 1s 1s +0%
shake256_absorb 1s 3s -67%

@oqs-bot

oqs-bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

CBMC Results (ML-DSA-65)

Full Results (205 proofs)
Proof Status Current Previous Change
**TOTAL** 2605s 2695s -3.3%
polyvecl_pointwise_acc_montgomery_c 353s 401s -12%
mld_invntt_layer 210s 225s -7%
rej_uniform_native 195s 203s -4%
mld_ct_memcmp 191s 200s -5%
sign_verify_internal 185s 185s +0%
poly_pointwise_montgomery_c 148s 145s +2%
rej_uniform_native_aarch64 119s 119s +0%
polyvec_matrix_expand 114s 117s -3%
sign_signature_internal 53s 51s +4%
mld_attempt_signature_generation 49s 51s -4%
mld_ntt_layer 44s 47s -6%
fqmul 42s 44s -5%
polyvec_matrix_expand_serial 32s 28s +14%
mld_ntt_butterfly_block 26s 23s +13%
keccakf1600x4_permute_native 24s 23s +4%
polyvec_matrix_pointwise_montgomery_yvec 22s 23s -4%
poly_ntt_c 20s 23s -13%
polyt0_unpack 17s 16s +6%
rej_uniform_c 17s 17s +0%
poly_chknorm_c 16s 18s -11%
rej_uniform 16s 15s +7%
mld_check_pct 15s 15s +0%
polyveck_decompose 14s 17s -18%
compute_pack_t0_t1 13s 14s -7%
poly_invntt_tomont_c 12s 10s +20%
poly_uniform_4x 12s 13s -8%
polyz_unpack_c 12s 13s -8%
poly_uniform_eta_4x 11s 13s -15%
keccak_absorb_once_x4 10s 10s +0%
mld_compute_pack_z 10s 9s +11%
polyeta_unpack 8s 6s +33%
polyveck_invntt_tomont 8s 9s -11%
sign 8s 9s -11%
mld_keccakf1600_permute_c 7s 5s +40%
pointwise_acc_native_x86_64 7s 6s +17%
poly_decompose_c 7s 6s +17%
poly_use_hint_c 7s 6s +17%
polyveck_caddq 7s 8s -12%
polyveck_ntt 7s 9s -22%
rej_eta 7s 2s +250%
mld_ct_cmask_nonzero_u32 6s 5s +20%
mld_h 6s 6s +0%
mld_sample_s1_s2_serial 6s 7s -14%
poly_add 6s 8s -25%
poly_pointwise_montgomery 6s 1s +500%
poly_uniform_eta 6s 4s +50%
polyveck_chknorm 6s 8s -25%
polyvecl_ntt 6s 5s +20%
sign_keypair_internal 6s 6s +0%
sign_pk_from_sk 6s 7s -14%
sign_verify_pre_hash_internal 6s 6s +0%
unpack_sk_s1hat 6s 4s +50%
unpack_sk_t0hat 6s 8s -25%
intt_native_x86_64 5s 3s +67%
keccak_absorb 5s 6s -17%
keccak_f1600_x1_native_aarch64 5s 3s +67%
keccak_squeezeblocks_x4 5s 5s +0%
pack_sk_s1 5s 2s +150%
pointwise_acc_native_aarch64 5s 6s -17%
poly_chknorm_native 5s 4s +25%
poly_uniform 5s 4s +25%
polyt1_unpack 5s 6s -17%
polyvec_matrix_pointwise_montgomery_row 5s 3s +67%
polyveck_pack_eta 5s 4s +25%
polyz_unpack 5s 2s +150%
power2round 5s 2s +150%
sig_unpack_hints 5s 5s +0%
sign_signature 5s 3s +67%
sign_signature_pre_hash_internal 5s 3s +67%
sign_verify_extmu 5s 4s +25%
sk_t0hat_get_poly 5s 3s +67%
fqscale 4s 2s +100%
intt_native_aarch64 4s 3s +33%
keccakf1600_extract_bytes (big endian) 4s 3s +33%
keccakf1600_xor_bytes 4s 3s +33%
keccakf1600x4_extract_bytes_native 4s 1s +300%
keccakf1600x4_permute 4s 2s +100%
keccakf1600x4_xor_bytes_native 4s 2s +100%
mld_ct_abs_i32 4s 3s +33%
mld_keccakf1600_extract_bytes 4s 2s +100%
mld_prepare_domain_separation_prefix 4s 6s -33%
poly_caddq_native 4s 3s +33%
poly_challenge 4s 4s +0%
poly_decompose 4s 2s +100%
poly_decompose_native 4s 5s -20%
poly_invntt_tomont 4s 4s +0%
poly_invntt_tomont_native 4s 3s +33%
poly_ntt 4s 2s +100%
poly_permute_bitrev_to_custom_optional 4s 2s +100%
poly_pointwise_montgomery_native 4s 4s +0%
poly_uniform_gamma1_4x 4s 5s -20%
polyveck_pack_w1 4s 4s +0%
polyveck_reduce 4s 3s +33%
polyvecl_chknorm 4s 4s +0%
polyvecl_uniform_gamma1 4s 2s +100%
polyw1_pack_88 4s 3s +33%
rej_eta_native 4s 5s -20%
shake128_absorb 4s 2s +100%
shake128x4_absorb_once 4s 3s +33%
shake256_absorb 4s 2s +100%
shake256x4_absorb_once 4s 4s +0%
sign_keypair 4s 3s +33%
sign_open 4s 4s +0%
sign_signature_pre_hash_shake256 4s 3s +33%
sign_verify 4s 2s +100%
sign_verify_pre_hash_shake256 4s 2s +100%
yvec_get_poly 4s 2s +100%
caddq 3s 3s +0%
decompose 3s 3s +0%
keccak_f1600_x1_native_aarch64_v84a 3s 4s -25%
keccakf1600x4_extract_bytes 3s 4s -25%
keccakf1600x4_xor_bytes 3s 2s +50%
mld_ct_get_optblocker_u8 3s 1s +200%
mld_keccakf1600x4_xor_bytes_c 3s 2s +50%
mld_polymat_expand_entry 3s 3s +0%
ntt_native_aarch64 3s 4s -25%
nttunpack_native_x86_64 3s 5s -40%
pack_sig_c 3s 6s -50%
pack_sig_z 3s 3s +0%
pack_sk_rho_key_tr_s2 3s 4s -25%
pointwise_native_aarch64 3s 4s -25%
pointwise_native_x86_64 3s 2s +50%
poly_caddq_native_aarch64 3s 2s +50%
poly_chknorm 3s 4s -25%
poly_chknorm_native_aarch64 3s 3s +0%
poly_decompose_32_native_aarch64 3s 4s -25%
poly_ntt_native 3s 3s +0%
poly_reduce 3s 4s -25%
poly_shiftl 3s 3s +0%
poly_sub 3s 2s +50%
polyvecl_unpack_z 3s 5s -40%
polyz_unpack_17_native_aarch64 3s 5s -40%
rej_eta_c 3s 3s +0%
shake128_squeeze 3s 3s +0%
shake128x4_squeezeblocks 3s 3s +0%
shake256_finalize 3s 2s +50%
shake256_init 3s 1s +200%
shake256_release 3s 2s +50%
sign_signature_extmu 3s 3s +0%
unpack_sk 3s 3s +0%
use_hint 3s 3s +0%
yvec_init 3s 3s +0%
keccak_f1600_x4_native_aarch64_v84a 2s 2s +0%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 2s 1s +100%
keccak_f1600_x4_native_avx2 2s 3s -33%
keccak_finalize 2s 4s -50%
keccak_init 2s 2s +0%
keccak_squeeze 2s 2s +0%
keccakf1600_permute_native 2s 2s +0%
keccakf1600_xor_bytes (big endian) 2s 3s -33%
make_hint 2s 3s -33%
mld_ct_cmask_neg_i32 2s 3s -33%
mld_ct_cmask_nonzero_u8 2s 4s -50%
mld_ct_get_optblocker_i64 2s 2s +0%
mld_ct_get_optblocker_u32 2s 2s +0%
mld_ct_sel_int32 2s 2s +0%
mld_keccakf1600x4_extract_bytes_c 2s 2s +0%
mld_sample_s1_s2 2s 6s -67%
mld_value_barrier_u32 2s 1s +100%
mld_value_barrier_u8 2s 2s +0%
montgomery_reduce 2s 2s +0%
ntt_native_x86_64 2s 4s -50%
pack_sig_h 2s 3s -33%
poly_caddq 2s 3s -33%
poly_caddq_c 2s 3s -33%
poly_caddq_native_x86_64 2s 4s -50%
poly_chknorm_native_x86_64 2s 3s -33%
poly_decompose_88_native_aarch64 2s 3s -33%
poly_permute_bitrev_to_custom_optional_native 2s 4s -50%
poly_power2round 2s 4s -50%
poly_uniform_gamma1 2s 3s -33%
polyeta_pack 2s 2s +0%
polyt0_pack 2s 3s -33%
polyt1_pack 2s 3s -33%
polyveck_unpack_eta 2s 3s -33%
polyvecl_pack_eta 2s 4s -50%
polyvecl_pointwise_acc_montgomery 2s 4s -50%
polyvecl_pointwise_acc_montgomery_native 2s 2s +0%
polyvecl_unpack_eta 2s 2s +0%
polyw1_pack 2s 2s +0%
polyz_pack 2s 3s -33%
polyz_unpack_19_native_aarch64 2s 3s -33%
polyz_unpack_native 2s 4s -50%
polyz_unpack_native_x86_64 2s 3s -33%
rej_uniform_eta_native_aarch64 2s 5s -60%
shake128_finalize 2s 4s -50%
shake128_init 2s 2s +0%
shake256 2s 3s -33%
shake256x4_squeezeblocks 2s 1s +100%
sys_check_capability 2s 1s +100%
unpack_pk_t1 2s 1s +100%
unpack_sk_s2hat 2s 5s -60%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 1s 2s -50%
keccakf1600_permute 1s 1s +0%
mld_value_barrier_i64 1s 3s -67%
poly_use_hint 1s 4s -75%
poly_use_hint_native 1s 3s -67%
poly_use_hint_native_aarch64 1s 2s -50%
polyvecl_uniform_gamma1_serial 1s 3s -67%
polyw1_pack_32 1s 1s +0%
reduce32 1s 3s -67%
shake128_release 1s 3s -67%
shake256_squeeze 1s 3s -67%
sk_s1hat_get_poly 1s 4s -75%
sk_s2hat_get_poly 1s 4s -75%

@oqs-bot

oqs-bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

CBMC Results (ML-DSA-44)

Full Results (205 proofs)
Proof Status Current Previous Change
**TOTAL** 2563s 2752s -6.9%
polyvecl_pointwise_acc_montgomery_c 493s 587s -16%
mld_invntt_layer 214s 226s -5%
mld_ct_memcmp 195s 214s -9%
rej_uniform_native 192s 207s -7%
poly_pointwise_montgomery_c 144s 147s -2%
sign_verify_internal 124s 132s -6%
rej_uniform_native_aarch64 118s 119s -1%
compute_pack_t0_t1 54s 54s +0%
mld_attempt_signature_generation 52s 55s -5%
mld_ntt_layer 44s 47s -6%
fqmul 43s 44s -2%
polyvec_matrix_expand 31s 30s +3%
mld_ntt_butterfly_block 23s 24s -4%
keccakf1600x4_permute_native 21s 22s -5%
poly_ntt_c 20s 22s -9%
polyeta_unpack 17s 15s +13%
polyvec_matrix_pointwise_montgomery_yvec 17s 19s -11%
sign_signature_internal 17s 20s -15%
polyt0_unpack 16s 16s +0%
rej_uniform 16s 17s -6%
rej_uniform_c 16s 19s -16%
mld_check_pct 15s 16s -6%
poly_chknorm_c 15s 17s -12%
poly_uniform_4x 12s 15s -20%
poly_uniform_eta_4x 12s 12s +0%
poly_invntt_tomont_c 11s 13s -15%
polyz_unpack_c 11s 11s +0%
keccak_absorb_once_x4 9s 12s -25%
polyvecl_chknorm 9s 13s -31%
rej_eta_c 8s 4s +100%
sign_pk_from_sk 8s 6s +33%
sign_verify_pre_hash_internal 8s 6s +33%
poly_add 7s 10s -30%
poly_shiftl 7s 3s +133%
polyvec_matrix_expand_serial 7s 8s -12%
fqscale 6s 4s +50%
mld_keccakf1600_permute_c 6s 8s -25%
nttunpack_native_x86_64 6s 5s +20%
pointwise_acc_native_aarch64 6s 5s +20%
polyt1_unpack 6s 4s +50%
polyveck_caddq 6s 7s -14%
polyveck_decompose 6s 4s +50%
polyvecl_uniform_gamma1_serial 6s 3s +100%
rej_eta_native 6s 5s +20%
sign 6s 9s -33%
sign_signature_extmu 6s 3s +100%
decompose 5s 2s +150%
intt_native_x86_64 5s 3s +67%
mld_compute_pack_z 5s 5s +0%
mld_ct_abs_i32 5s 2s +150%
mld_h 5s 3s +67%
mld_prepare_domain_separation_prefix 5s 3s +67%
pointwise_acc_native_x86_64 5s 8s -38%
poly_challenge 5s 3s +67%
poly_decompose_c 5s 6s -17%
poly_invntt_tomont 5s 4s +25%
poly_pointwise_montgomery 5s 4s +25%
poly_uniform 5s 5s +0%
polyveck_chknorm 5s 4s +25%
polyveck_ntt 5s 5s +0%
polyveck_reduce 5s 2s +150%
polyveck_unpack_eta 5s 2s +150%
polyvecl_pointwise_acc_montgomery_native 5s 2s +150%
polyz_unpack_17_native_aarch64 5s 5s +0%
rej_uniform_eta_native_aarch64 5s 3s +67%
sign_keypair_internal 5s 5s +0%
sign_signature_pre_hash_internal 5s 3s +67%
sign_verify_pre_hash_shake256 5s 5s +0%
caddq 4s 3s +33%
keccak_f1600_x4_native_avx2 4s 3s +33%
keccak_squeezeblocks_x4 4s 4s +0%
keccakf1600x4_extract_bytes_native 4s 3s +33%
mld_keccakf1600x4_xor_bytes_c 4s 3s +33%
mld_sample_s1_s2 4s 6s -33%
ntt_native_aarch64 4s 2s +100%
pointwise_native_x86_64 4s 4s +0%
poly_chknorm_native_aarch64 4s 3s +33%
poly_chknorm_native_x86_64 4s 3s +33%
poly_decompose 4s 2s +100%
poly_invntt_tomont_native 4s 4s +0%
polyt0_pack 4s 3s +33%
polyt1_pack 4s 3s +33%
polyveck_invntt_tomont 4s 6s -33%
polyw1_pack_88 4s 3s +33%
polyz_pack 4s 3s +33%
power2round 4s 3s +33%
shake256_init 4s 3s +33%
sig_unpack_hints 4s 3s +33%
sign_signature_pre_hash_shake256 4s 6s -33%
sign_verify_extmu 4s 4s +0%
sk_s2hat_get_poly 4s 2s +100%
sys_check_capability 4s 5s -20%
unpack_sk_s1hat 4s 5s -20%
unpack_sk_t0hat 4s 5s -20%
intt_native_aarch64 3s 4s -25%
keccak_absorb 3s 6s -50%
keccak_f1600_x1_native_aarch64 3s 2s +50%
keccak_f1600_x1_native_aarch64_v84a 3s 4s -25%
keccak_f1600_x4_native_aarch64_v84a 3s 2s +50%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 3s 2s +50%
keccak_squeeze 3s 2s +50%
keccakf1600_permute 3s 3s +0%
keccakf1600_permute_native 3s 4s -25%
keccakf1600_xor_bytes (big endian) 3s 2s +50%
keccakf1600x4_xor_bytes 3s 2s +50%
keccakf1600x4_xor_bytes_native 3s 2s +50%
make_hint 3s 3s +0%
mld_ct_cmask_neg_i32 3s 1s +200%
mld_ct_cmask_nonzero_u32 3s 4s -25%
mld_ct_cmask_nonzero_u8 3s 2s +50%
mld_keccakf1600_extract_bytes 3s 5s -40%
mld_keccakf1600x4_extract_bytes_c 3s 3s +0%
mld_polymat_expand_entry 3s 5s -40%
mld_sample_s1_s2_serial 3s 3s +0%
mld_value_barrier_i64 3s 1s +200%
mld_value_barrier_u8 3s 3s +0%
ntt_native_x86_64 3s 2s +50%
pack_sig_c 3s 2s +50%
pack_sk_rho_key_tr_s2 3s 2s +50%
pack_sk_s1 3s 1s +200%
pointwise_native_aarch64 3s 3s +0%
poly_caddq 3s 5s -40%
poly_caddq_c 3s 2s +50%
poly_caddq_native 3s 3s +0%
poly_chknorm 3s 3s +0%
poly_chknorm_native 3s 5s -40%
poly_decompose_32_native_aarch64 3s 2s +50%
poly_decompose_88_native_aarch64 3s 2s +50%
poly_decompose_native 3s 4s -25%
poly_ntt 3s 3s +0%
poly_power2round 3s 5s -40%
poly_uniform_eta 3s 4s -25%
poly_uniform_gamma1_4x 3s 6s -50%
poly_use_hint 3s 3s +0%
poly_use_hint_c 3s 4s -25%
poly_use_hint_native 3s 2s +50%
poly_use_hint_native_aarch64 3s 4s -25%
polyeta_pack 3s 5s -40%
polyveck_pack_eta 3s 3s +0%
polyvecl_unpack_eta 3s 2s +50%
polyvecl_unpack_z 3s 4s -25%
polyw1_pack 3s 3s +0%
polyw1_pack_32 3s 3s +0%
polyz_unpack_native 3s 5s -40%
rej_eta 3s 1s +200%
shake128_finalize 3s 2s +50%
shake128_init 3s 5s -40%
shake128x4_squeezeblocks 3s 3s +0%
shake256_absorb 3s 2s +50%
shake256_squeeze 3s 2s +50%
shake256x4_absorb_once 3s 1s +200%
sign_keypair 3s 2s +50%
sign_open 3s 4s -25%
sign_verify 3s 5s -40%
unpack_pk_t1 3s 3s +0%
yvec_get_poly 3s 4s -25%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 2s 3s -33%
keccak_init 2s 3s -33%
keccakf1600_extract_bytes (big endian) 2s 3s -33%
keccakf1600_xor_bytes 2s 2s +0%
keccakf1600x4_permute 2s 2s +0%
mld_ct_get_optblocker_i64 2s 2s +0%
mld_ct_get_optblocker_u32 2s 2s +0%
mld_ct_get_optblocker_u8 2s 2s +0%
mld_ct_sel_int32 2s 3s -33%
mld_value_barrier_u32 2s 5s -60%
montgomery_reduce 2s 4s -50%
pack_sig_h 2s 3s -33%
poly_caddq_native_aarch64 2s 2s +0%
poly_caddq_native_x86_64 2s 3s -33%
poly_ntt_native 2s 4s -50%
poly_permute_bitrev_to_custom_optional 2s 4s -50%
poly_permute_bitrev_to_custom_optional_native 2s 3s -33%
poly_pointwise_montgomery_native 2s 3s -33%
poly_sub 2s 4s -50%
poly_uniform_gamma1 2s 3s -33%
polyvec_matrix_pointwise_montgomery_row 2s 3s -33%
polyveck_pack_w1 2s 5s -60%
polyvecl_ntt 2s 3s -33%
polyvecl_pointwise_acc_montgomery 2s 2s +0%
polyvecl_uniform_gamma1 2s 2s +0%
polyz_unpack 2s 4s -50%
polyz_unpack_19_native_aarch64 2s 3s -33%
polyz_unpack_native_x86_64 2s 2s +0%
reduce32 2s 1s +100%
shake128_absorb 2s 2s +0%
shake128_release 2s 4s -50%
shake128_squeeze 2s 4s -50%
shake128x4_absorb_once 2s 1s +100%
shake256 2s 3s -33%
shake256_finalize 2s 2s +0%
sign_signature 2s 3s -33%
sk_s1hat_get_poly 2s 3s -33%
sk_t0hat_get_poly 2s 4s -50%
unpack_sk 2s 3s -33%
unpack_sk_s2hat 2s 4s -50%
use_hint 2s 3s -33%
yvec_init 2s 2s +0%
keccak_finalize 1s 4s -75%
keccakf1600x4_extract_bytes 1s 1s +0%
pack_sig_z 1s 4s -75%
poly_reduce 1s 3s -67%
polyvecl_pack_eta 1s 3s -67%
shake256_release 1s 4s -75%
shake256x4_squeezeblocks 1s 2s -50%

@oqs-bot

oqs-bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

CBMC Results (ML-DSA-87)

Full Results (205 proofs)
Proof Status Current Previous Change
**TOTAL** 3114s 2999s +3.8%
polyvecl_pointwise_acc_montgomery_c 703s 664s +6%
polyvec_matrix_expand 313s 309s +1%
mld_invntt_layer 206s 202s +2%
rej_uniform_native 190s 188s +1%
mld_ct_memcmp 189s 185s +2%
poly_pointwise_montgomery_c 135s 131s +3%
mld_attempt_signature_generation 119s 120s -1%
rej_uniform_native_aarch64 116s 114s +2%
sign_verify_internal 98s 95s +3%
mld_ntt_layer 46s 43s +7%
fqmul 41s 40s +2%
polyvec_matrix_expand_serial 38s 36s +6%
sign_signature_internal 28s 29s -3%
keccakf1600x4_permute_native 22s 21s +5%
mld_ntt_butterfly_block 21s 20s +5%
polyvec_matrix_pointwise_montgomery_yvec 20s 20s +0%
compute_pack_t0_t1 19s 18s +6%
poly_ntt_c 19s 20s -5%
polyeta_unpack 18s 15s +20%
rej_uniform_c 17s 14s +21%
polyt0_unpack 16s 15s +7%
mld_check_pct 15s 14s +7%
poly_chknorm_c 14s 16s -12%
poly_uniform_4x 14s 12s +17%
rej_uniform 14s 14s +0%
poly_invntt_tomont_c 12s 10s +20%
poly_uniform_eta_4x 12s 12s +0%
mld_compute_pack_z 11s 9s +22%
polyveck_decompose 10s 12s -17%
keccak_absorb_once_x4 9s 9s +0%
pointwise_acc_native_x86_64 9s 6s +50%
polyveck_ntt 9s 8s +12%
sign 9s 7s +29%
polyvecl_ntt 8s 7s +14%
mld_keccakf1600_permute_c 7s 8s -12%
pointwise_acc_native_aarch64 7s 6s +17%
polyveck_caddq 7s 7s +0%
polyveck_invntt_tomont 7s 7s +0%
sign_pk_from_sk 7s 6s +17%
sign_verify 7s 3s +133%
unpack_sk_t0hat 7s 6s +17%
keccak_squeezeblocks_x4 6s 4s +50%
mld_h 6s 2s +200%
mld_keccakf1600x4_extract_bytes_c 6s 4s +50%
mld_sample_s1_s2 6s 7s -14%
mld_sample_s1_s2_serial 6s 6s +0%
poly_add 6s 6s +0%
poly_challenge 6s 7s -14%
poly_decompose_c 6s 7s -14%
poly_permute_bitrev_to_custom_optional_native 6s 4s +50%
poly_uniform_eta 6s 3s +100%
rej_eta_native 6s 5s +20%
sign_open 6s 4s +50%
intt_native_aarch64 5s 4s +25%
intt_native_x86_64 5s 2s +150%
keccakf1600_xor_bytes (big endian) 5s 4s +25%
poly_chknorm_native 5s 5s +0%
poly_ntt 5s 3s +67%
poly_pointwise_montgomery_native 5s 2s +150%
poly_sub 5s 3s +67%
poly_use_hint_c 5s 4s +25%
poly_use_hint_native_aarch64 5s 3s +67%
polyvec_matrix_pointwise_montgomery_row 5s 3s +67%
reduce32 5s 3s +67%
sign_keypair_internal 5s 5s +0%
sign_signature 5s 4s +25%
use_hint 5s 3s +67%
caddq 4s 3s +33%
keccak_f1600_x4_native_aarch64_v84a 4s 3s +33%
keccak_f1600_x4_native_avx2 4s 3s +33%
keccakf1600_permute_native 4s 3s +33%
mld_ct_abs_i32 4s 2s +100%
mld_ct_get_optblocker_u8 4s 3s +33%
mld_prepare_domain_separation_prefix 4s 5s -20%
mld_value_barrier_i64 4s 3s +33%
mld_value_barrier_u8 4s 3s +33%
montgomery_reduce 4s 2s +100%
ntt_native_x86_64 4s 5s -20%
nttunpack_native_x86_64 4s 2s +100%
pack_sk_s1 4s 2s +100%
poly_caddq 4s 3s +33%
poly_decompose_native 4s 3s +33%
poly_power2round 4s 2s +100%
poly_uniform 4s 2s +100%
polyeta_pack 4s 4s +0%
polyt1_unpack 4s 5s -20%
polyveck_pack_eta 4s 2s +100%
polyveck_pack_w1 4s 2s +100%
polyveck_reduce 4s 2s +100%
polyvecl_chknorm 4s 3s +33%
polyvecl_pointwise_acc_montgomery_native 4s 6s -33%
polyz_pack 4s 2s +100%
polyz_unpack 4s 3s +33%
polyz_unpack_native 4s 3s +33%
rej_eta 4s 6s -33%
rej_eta_c 4s 3s +33%
shake128_finalize 4s 3s +33%
shake128_squeeze 4s 1s +300%
shake256_absorb 4s 2s +100%
shake256x4_absorb_once 4s 3s +33%
sign_signature_pre_hash_internal 4s 5s -20%
sign_signature_pre_hash_shake256 4s 5s -20%
sign_verify_pre_hash_internal 4s 5s -20%
unpack_pk_t1 4s 2s +100%
unpack_sk 4s 5s -20%
unpack_sk_s1hat 4s 2s +100%
decompose 3s 2s +50%
fqscale 3s 4s -25%
keccak_f1600_x1_native_aarch64 3s 3s +0%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 3s 3s +0%
keccak_finalize 3s 1s +200%
keccakf1600_extract_bytes (big endian) 3s 5s -40%
keccakf1600x4_xor_bytes 3s 3s +0%
keccakf1600x4_xor_bytes_native 3s 2s +50%
make_hint 3s 3s +0%
mld_ct_cmask_neg_i32 3s 3s +0%
mld_ct_cmask_nonzero_u32 3s 3s +0%
mld_ct_get_optblocker_i64 3s 1s +200%
mld_keccakf1600_extract_bytes 3s 2s +50%
mld_keccakf1600x4_xor_bytes_c 3s 2s +50%
pack_sig_h 3s 2s +50%
pack_sk_rho_key_tr_s2 3s 3s +0%
pointwise_native_aarch64 3s 3s +0%
pointwise_native_x86_64 3s 2s +50%
poly_caddq_c 3s 3s +0%
poly_caddq_native 3s 5s -40%
poly_caddq_native_aarch64 3s 5s -40%
poly_caddq_native_x86_64 3s 2s +50%
poly_chknorm 3s 2s +50%
poly_chknorm_native_aarch64 3s 3s +0%
poly_chknorm_native_x86_64 3s 2s +50%
poly_decompose 3s 3s +0%
poly_invntt_tomont_native 3s 2s +50%
poly_permute_bitrev_to_custom_optional 3s 3s +0%
poly_pointwise_montgomery 3s 2s +50%
poly_reduce 3s 3s +0%
poly_shiftl 3s 4s -25%
poly_uniform_gamma1 3s 3s +0%
poly_uniform_gamma1_4x 3s 4s -25%
poly_use_hint_native 3s 5s -40%
polyt0_pack 3s 4s -25%
polyveck_chknorm 3s 3s +0%
polyveck_unpack_eta 3s 2s +50%
polyvecl_pack_eta 3s 3s +0%
polyvecl_pointwise_acc_montgomery 3s 2s +50%
polyvecl_uniform_gamma1 3s 3s +0%
polyvecl_uniform_gamma1_serial 3s 4s -25%
polyvecl_unpack_eta 3s 3s +0%
polyvecl_unpack_z 3s 5s -40%
polyw1_pack 3s 3s +0%
polyz_unpack_17_native_aarch64 3s 2s +50%
polyz_unpack_19_native_aarch64 3s 3s +0%
polyz_unpack_native_x86_64 3s 1s +200%
rej_uniform_eta_native_aarch64 3s 2s +50%
shake128_absorb 3s 2s +50%
shake256_finalize 3s 1s +200%
sig_unpack_hints 3s 2s +50%
sign_keypair 3s 5s -40%
sign_signature_extmu 3s 3s +0%
sign_verify_extmu 3s 5s -40%
sign_verify_pre_hash_shake256 3s 2s +50%
sk_t0hat_get_poly 3s 3s +0%
sys_check_capability 3s 3s +0%
unpack_sk_s2hat 3s 5s -40%
yvec_get_poly 3s 2s +50%
keccak_absorb 2s 5s -60%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 2s 2s +0%
keccak_init 2s 1s +100%
keccak_squeeze 2s 3s -33%
keccakf1600_permute 2s 3s -33%
keccakf1600x4_extract_bytes 2s 2s +0%
keccakf1600x4_extract_bytes_native 2s 3s -33%
mld_ct_cmask_nonzero_u8 2s 2s +0%
mld_ct_get_optblocker_u32 2s 2s +0%
mld_ct_sel_int32 2s 3s -33%
mld_polymat_expand_entry 2s 3s -33%
mld_value_barrier_u32 2s 1s +100%
ntt_native_aarch64 2s 2s +0%
pack_sig_c 2s 6s -67%
pack_sig_z 2s 1s +100%
poly_decompose_32_native_aarch64 2s 2s +0%
poly_decompose_88_native_aarch64 2s 5s -60%
poly_invntt_tomont 2s 5s -60%
poly_ntt_native 2s 3s -33%
polyw1_pack_32 2s 3s -33%
polyz_unpack_c 2s 4s -50%
power2round 2s 3s -33%
shake128_init 2s 2s +0%
shake128x4_absorb_once 2s 2s +0%
shake128x4_squeezeblocks 2s 2s +0%
shake256 2s 4s -50%
shake256_init 2s 5s -60%
shake256_release 2s 5s -60%
sk_s2hat_get_poly 2s 4s -50%
yvec_init 2s 4s -50%
keccak_f1600_x1_native_aarch64_v84a 1s 1s +0%
keccakf1600_xor_bytes 1s 2s -50%
keccakf1600x4_permute 1s 3s -67%
poly_use_hint 1s 4s -75%
polyt1_pack 1s 4s -75%
polyw1_pack_88 1s 4s -75%
shake128_release 1s 2s -50%
shake256_squeeze 1s 3s -67%
shake256x4_squeezeblocks 1s 3s -67%
sk_s1hat_get_poly 1s 2s -50%

Comment thread test/src/test_mldsa.c
Comment on lines +214 to +215
MLD_CT_TESTING_DECLASSIFY(&rc, sizeof(rc));
MLD_CT_TESTING_DECLASSIFY(&siglen, sizeof(siglen));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't those declassifications are necessary? Those values should be public already, I believe.

Comment thread test/src/test_mldsa.c
Comment on lines +202 to +205
CHECK(randombytes(ph1, sizeof(ph1)) == 0);
MLD_CT_TESTING_SECRET(ph1, sizeof(ph1));
CHECK(randombytes(ph2, sizeof(ph2)) == 0);
MLD_CT_TESTING_SECRET(ph2, sizeof(ph2));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between the tests exercising ph1 vs. ph2?

Comment thread mldsa/mldsa_native.h
Comment on lines 635 to +640
* Supported hash algorithm constants:
* MLD_PREHASH_SHA2_224, MLD_PREHASH_SHA2_256, MLD_PREHASH_SHA2_384,
* MLD_PREHASH_SHA2_512, MLD_PREHASH_SHA2_512_224, MLD_PREHASH_SHA2_512_256,
* MLD_PREHASH_SHA3_224, MLD_PREHASH_SHA3_256, MLD_PREHASH_SHA3_384,
* MLD_PREHASH_SHA3_512, MLD_PREHASH_SHAKE_128, MLD_PREHASH_SHAKE_256.
* MLD_PREHASH_NONE is rejected by this HashML-DSA API.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This is still indented under the Supported hash algorithm constants: block.

Suggestion:

Suggested change
* MLD_PREHASH_NONE is rejected by this HashML-DSA API.
* Supported hash algorithm constants:
* MLD_PREHASH_SHA2_224, MLD_PREHASH_SHA2_256, MLD_PREHASH_SHA2_384,
* MLD_PREHASH_SHA2_512, MLD_PREHASH_SHA2_512_224, MLD_PREHASH_SHA2_512_256,
* MLD_PREHASH_SHA3_224, MLD_PREHASH_SHA3_256, MLD_PREHASH_SHA3_384,
* MLD_PREHASH_SHA3_512, MLD_PREHASH_SHAKE_128, MLD_PREHASH_SHAKE_256.
*
* MLD_PREHASH_NONE is rejected by this API.

@hanno-becker hanno-becker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fegge, I support this change.

Minor nit regarding the documentation, and I believe the test can be simplified -- see comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prehash API accepts MLD_PREHASH_NONE and ignores the digest

3 participants