Document signing secret-key validity precondition#1229
Open
fegge wants to merge 1 commit into
Open
Conversation
Signed-off-by: Fredrik Dahlgren <fredrik.dahlgren@trailofbits.com>
This was referenced Jun 26, 2026
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-44)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (205 proofs)
|
Comment on lines
+197
to
+198
| * @param[in] sk Bit-packed valid secret key. Signing does not perform | ||
| * full serialized secret-key validation; callers |
Contributor
There was a problem hiding this comment.
Should we make this more prominent? E.g.
Bit-packed secret key; assumed to be valid.
and further above/below
@warning This function does not perform secret key validation.
Callers importing serialized keys can use mld_sign_pk_from_sk
to validate them before signing.
@mkannwischer wdyt
It also sheds light that we might want to provide an explicit mld_sign_sk_validate or similar (even if it's just a dummy around mld_sign_pk_from_sk). Proposing to call mld_sign_pk_from_sk for key validation and throwing away pk is, at best, unintuitive.
hanno-becker
requested changes
Jun 27, 2026
hanno-becker
left a comment
Contributor
There was a problem hiding this comment.
Thank you @fegge, I support this change. One could even make the comment more prominent, see comment. @mkannwischer wdyt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pk_from_skwhen they need to validate a serialized secret key before signing.InvalidPrivateKeysigning vectors are skipped whilepkFromSkstill tests those keys.Validation
clang-format -i mldsa/src/sign.h mldsa/mldsa_native.h: passedruff format test/wycheproof/wycheproof_client.py: passedruff check test/wycheproof/wycheproof_client.py: passedpython3 -m py_compile test/wycheproof/wycheproof_client.py: passedgit diff --check -- mldsa/src/sign.h mldsa/mldsa_native.h test/wycheproof/wycheproof_client.py: passedmake run_func -j4: passedmake wycheproof -j4: passedpython3 test/wycheproof/wycheproof_client.py --data-dir <fresh-temp-dir>: passed./scripts/formatbecausenixpkgs-fmtis not installed in this local environment./scripts/lintbecauseshfmtis not installed in this local environmentFixes #1216
This work was completed by Trail of Bits as part of the Patch The Planet project in collaboration with OpenAI. The issue was identified primarily by the Codex coding agent, and manually reviewed before submission.