Fix domain and subdomain extraction logic.#2
Open
th0mcat wants to merge 2 commits intopradoh97:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you very much for creating this script!
Tl;dr: The extraction logic apparently doesn't work for a base domain
I wasn't sure how it worked, so I tried setting a CERTBOT_DOMAIN environment variable and then a global variable directly into the script, which obviously didn't work. I threw it into Gemini (:sigh: sorry!) to have it explain it to me, where it told me this was for Certbot itself and to use the
--manual-auth-hook. It also said:Then it provided the following fixes. Feel free to ignore since it's AI slop, but this worked for me.