Skip to content

Add Contains method with StringComparison parameter.#1208

Open
microspaze wants to merge 3 commits into
praeclarum:masterfrom
microspaze:master
Open

Add Contains method with StringComparison parameter.#1208
microspaze wants to merge 3 commits into
praeclarum:masterfrom
microspaze:master

Conversation

@microspaze

@microspaze microspaze commented Jan 16, 2024

Copy link
Copy Markdown

Modified from older commit: 9040c0b

Remove useless Contains extension method and fix args unmatch bug.

@praeclarum

Copy link
Copy Markdown
Owner

Hello, thank you very much. I wonder if you wouldn't mind splitting this PR into two: one with your DefaultValue change (which needs some tests) and the comparison changes. I like your code, for the StringComparison :-)

@microspaze

Copy link
Copy Markdown
Author

@praeclarum I have revert the commit of DefaultValue on my master branch. Now the merge request is clean. Please verify
when you are convenient. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants