Fix support for struct in query results by disabling fast column setters#1266
Open
gilzoide wants to merge 1 commit into
Open
Fix support for struct in query results by disabling fast column setters#1266gilzoide wants to merge 1 commit into
gilzoide wants to merge 1 commit into
Conversation
|
Hi @praeclarum, do you know if this will be merged in to the codebase please? |
|
Bump, this should be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using struct types as query return raises
ArgumentExceptiononFastColumnSettercode because property setter delegates for structs should useref ObjectTypefor its first parameter (#1075). This PR disables the usage of fast column setters for value types, fixing support for queries with struct returns.