Fix footnote definitions absorbing subsequent document content#524
Open
maennchen wants to merge 1 commit into
Open
Fix footnote definitions absorbing subsequent document content#524maennchen wants to merge 1 commit into
maennchen wants to merge 1 commit into
Conversation
Footnote definitions were terminating the main parse loop and feeding all remaining lines into the footnote body collector, causing content after a footnote definition to be nested inside its `li` node. The `div.footnotes` block was also placed at the position of the first footnote rather than at the end of the document. Rewrite `FootnoteParser` to partition lines into per-footnote bodies (blank/indented continuations) and regular document lines, parse each separately, and append `FnList` at the end of the document.
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Footnote definitions were terminating the main parse loop and feeding all remaining lines into the footnote body collector, causing content after a footnote definition to be nested inside its
linode. Thediv.footnotesblock was also placed at the position of the first footnote rather than at the end of the document.Rewrite
FootnoteParserto partition lines into per-footnote bodies (blank/indented continuations) and regular document lines, parse each separately, and appendFnListat the end of the document.