Skip to content

Feature/Json2Converter#43

Open
CrownPab wants to merge 6 commits into
pratyushtiwary:mainfrom
CrownPab:feature/Json2Converter
Open

Feature/Json2Converter#43
CrownPab wants to merge 6 commits into
pratyushtiwary:mainfrom
CrownPab:feature/Json2Converter

Conversation

@CrownPab

Copy link
Copy Markdown

Module for Json conversion has been added. Module can successfully convert JSON to YAML, JSON to CSV, and vice versa. 2 npm Packages have been added to complete this module. Resolves #13

@vercel

vercel Bot commented Oct 17, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devty ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 7:45pm

Comment on lines +57 to +61
<select id="inputType" v-model="inputType">
<option value="json">JSON</option>
<option value="yaml">YAML</option>
<option value="csv">CSV</option>
</select>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Balm UI's ui-select

@pratyushtiwary

Copy link
Copy Markdown
Owner

Can you please use useThrottle and update result when user updates input?

Also the CSV conversion is not working
image

@pratyushtiwary

Copy link
Copy Markdown
Owner

Please use built-in Select component. Use this as reference.

Also the CSV conversion is still not working for me. You can add a check that if the input starts with { then put that input in []

Also YAML to CSV is not working. You can convert YAML to JSON then to CSV.

Changing Input Type and Output Type doesn't reflect the change in the output.

If you need any help feel free to message me on discord or comment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Module Addition] JSON Converter

2 participants