Open
Conversation
genuine-seok
commented
Oct 30, 2022
genuine-seok
commented
- 미구현 기능 : 무한 스크롤, 광고 배너 삽입
- README 누락
- 페이지 컴포넌트 (Issues,Issue,NotFound) - 공통 컴포넌트 (Header, Layout, Error, Loading) - Issue 모듈 컴포넌트 (BannerItem,IssueDetail,IssueItem,IssueList) - react-markdown 마크다운 렌더러 패키지 및 관련 함수 추가
- axios client, IssueService 추가 - 비동기 통신 hook 추가 (useAsync)
- 무한스크롤 custom hook 추가 - Issues, IssueList 컴포넌트 로직 리팩토링 - IssueService.getIssues page 파라미터 로직 추가 - useAsyncIssues custom hook 추가
- pre-commit, pre-push lint 스크립트 추가
- gh-pages 패키지 추가 - homepage key value 추가 (package.json) - Router basename 값 추가 - 환경 변수 이름 변경 (REACT_APP_GITHUB_ACCESS_TOKEN)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.