Support the Async/Await Plugin#6
Open
dennisvolkmer wants to merge 2 commits intopreactjs-templates:masterfrom
Open
Support the Async/Await Plugin#6dennisvolkmer wants to merge 2 commits intopreactjs-templates:masterfrom
dennisvolkmer wants to merge 2 commits intopreactjs-templates:masterfrom
Conversation
added 2 commits
August 24, 2018 08:56
For instance Async/Await Plugin (preact-cli-plugin-async) that accesses the babel conf object while processing the preact.conf.js. Move the .babelrc to the src folder. Otherwise the babel config is not yet processed when the preact.conf.js is being processed by preact.
Bump preact-cli version to 2.2.1 to support the plugin out of the box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the .babelrc to the src folder and bumped the version of preact-cli to the latest stable version.
That way the preact async plugin (https://github.com/developit/preact-cli-plugin-async) works out of the box with this template. The issue with the current version is, that the babel config is not yet processed when the prect.conf.js is processed by preact. The async plugin tries to access the babel conf object wich failes when compiling a prod build.
I made a repositiory that uses my fork, wehere you can find a working example that uses some async await code here: https://github.com/dennisvolkmer/preact-cli-widget-async-await-example