Add mapping tester reference results#212
Conversation
davidscn
left a comment
There was a problem hiding this comment.
That's a great step for more robust testing. Currently, tests are failing.
ac9c3ca to
91f154d
Compare
|
I rewrote the compare file to be actually helpful now. |
507e94d to
8898237
Compare
|
The results are still strange. When running With clang (both) release With gcc (preCICE) release I get With gcc (both) release I get In the CI, we get Clang debug Clang release GCC Debug GCC Release So, there seems to be enough variation in the nearest-projection to result in failing tests. The big question is why are these projection results different. Turned out that the Metis partitioning is also non-deterministic. |
5080e84 to
a70c9cd
Compare
a70c9cd to
48df5db
Compare
|
The NP mappings are indeed different between versions 1.86 and 1.87 of boost. |
The solution should be unique, or am I missing something? This sounds like a bug either in preCICE or boost geometry. The release notes of boost 1.87 do not mention anything which could sound related. |
|
So, the mappings map to different elements, but the effective difference in distance is tiny. I think this happens when a point is located on the edge between two triangles. Here I print out the polation elements and weights and then compute the projection point for the old and new boost. Given that our input functions are spacially dependent, this shouldn't lead to such a big difference in the output. Or could the different points impact the result this extremely in the output of ASTE? |
cd5a0b8 to
cf248be
Compare
|
I was able to trace this down to the NP mapping itself projecting to worse elements on macOS-latest. |
|
Merging now and rebasing the WIP RPs |
Main changes of this PR
This PR adds a mapping tester compare script and reference results.
The script checks:
Closes #208
Author's checklist
pre-commithook and usedpre-commit run --allto apply all available hooks.docs/README.md../changelog-entries/(create if necessary).precice/tutorials/aste-turbine.