Add the ability to export arbitrary files#60
Closed
robertlong wants to merge 2 commits intoprefrontalcortex:devfrom
Closed
Add the ability to export arbitrary files#60robertlong wants to merge 2 commits intoprefrontalcortex:devfrom
robertlong wants to merge 2 commits intoprefrontalcortex:devfrom
Conversation
|
Thanks! A general question first: seems you assume that adding files by path is the right way forward. Why no "ExportBuffer" or similar for just saying "here's a byte[]"? That seems more flexible (e.g. Files API doesn't exist on some platforms) |
Author
|
I've addressed the feedback in #73 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is used in Third Room's implementation of KHR_audio. Which allows you to pass through binary buffers to be written as bufferView references or uris in the final gltf export.