Add support for signed JWT passes on Android#6
Merged
foyarash merged 1 commit intopremieroctet:masterfrom Jun 26, 2025
Merged
Conversation
- Introduces the `addPassWithSignedJwt` method for Android, allowing passes to be added using signed JWTs. Updates documentation to reflect the new method and clarifies usage of unsigned and signed JWTs. - Also updates Android build configuration to use Java 17.
foyarash
approved these changes
Jun 26, 2025
Contributor
foyarash
left a comment
foyarash
left a comment
There was a problem hiding this comment.
Thanks for the PR ! LGTM
Contributor
Author
|
Thanks for the rapid review, release, and library 🩵! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addPassWithSignedJwtmethod for Android, allowing passes to be added using signed JWTs. Updates documentation to reflect the new method and clarifies usage of unsigned and signed JWTs.Closes #1
maybe closes #2 (assuming they could've been running into the same issue of trying to add a signed jwt against the unsigned workflow method)
Let me know you need anything else here @baptadn @foyarash -- I like that this library is written with the ExpoModules api and hope that we can continue to make it better!