Add tpcds refresh queries for sf1#3
Conversation
|
Why there are some empty sql files? |
wanglinsong
left a comment
wanglinsong
left a comment
There was a problem hiding this comment.
Please remove those empty files.
| cr_reversed_charge, | ||
| cr_merchant_credit, | ||
| cast(cr_net_loss as decimal(7,2)) | ||
| FROM crv; No newline at end of file |
There was a problem hiding this comment.
please add a \n at the end of all files
| "queries/refresh/LF_CR.sql", | ||
| "queries/verify_LF_CR.sql" | ||
| ] | ||
| } |
There was a problem hiding this comment.
any expected number of rows returned?
There was a problem hiding this comment.
so the expected number of rows is actually an expression like >=2. Do we support such expressions currently @wanglinsong ?
There was a problem hiding this comment.
How do you tell if the verification is successful?
There was a problem hiding this comment.
we can decide based on the number of rows getting returned. The number of rows getting returned can be >=2, and I am not sure if such an expression is currently supported.
There was a problem hiding this comment.
So there is a way to compare the output with a baseline result and is currently being used for ds_orderby flavor. We will extend that support for ds_refresh flavor as well.
ethanyzhang
force-pushed
the
main
branch
3 times, most recently
from
e189d61 to
f43d5e2
Compare
| "queries/refresh/LF_CR.sql", | ||
| "queries/verify_LF_CR.sql" | ||
| ] | ||
| } |
There was a problem hiding this comment.
How do you tell if the verification is successful?
pratyakshsharma
force-pushed
the
tpcds-refresh
branch
from
7a4e2e4 to
72b23c7
Compare
pratyakshsharma
force-pushed
the
tpcds-refresh
branch
from
5a8166d to
be4d3be
Compare
|
No impact to Gluten. Spark use tpc-queries-for-spark branch |
ethanyzhang
force-pushed
the
main
branch
2 times, most recently
from
6f32a1a to
b8de6a7
Compare
4 participants
Add data maintenance insert functions for tpc-ds sf1 scale factor. Currently only one stream is supported with insert functions.
Delete functions will be added in a separate PR.